Add authentication/firewall capability through shell call/args #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs. Based on work by Cliff Cyphers. https://github.com/ccyphers/websockify
|
This should be good for another review. |
|
Closing. You can do something similar with token hooks (#162), and this PR is quite old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on Cliff Cypher's work. (https://github.com/ccyphers/websockify/commit/852de017686dd930399252ac8f1cda00a15a7a4e)
Let me know what you think. I believe I addressed your notes on his commit request.
I included an example script 'auth.py' to show how token based authentication would work.
This seems to be working fairly well atm.
example call:
./websockify --auth-hook='python auth.py' 10000 host:5900