Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target_cfg fails in OS X #168

Closed
Downchuck opened this issue Apr 9, 2015 · 0 comments
Closed

target_cfg fails in OS X #168

Downchuck opened this issue Apr 9, 2015 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Downchuck
Copy link

From a fresh clone of noVNC calling a fresh websockify:

$ ./utils/launch.sh 
readlink: illegal option -- f
usage: readlink [-n] [file ...]
Warning: could not find self.pem
Using local websockify at /Users/..../Desktop/noVNC/websockify/run
Starting webserver and WebSockets proxy on port 6080
Traceback (most recent call last):
  File "/Users/.../Desktop/noVNC/websockify/run", line 5, in <module>
    websockify.websocketproxy.websockify_init()
  File "/Users/..../Desktop/noVNC/websockify/websockify/websocketproxy.py", line 436, in websockify_init
    server = WebSocketProxy(**opts.__dict__)
  File "/Users/..../Desktop/noVNC/websockify/websockify/websocketproxy.py", line 232, in __init__
    websocket.WebSocketServer.__init__(self, RequestHandlerClass, *args, **kwargs)
TypeError: __init__() got an unexpected keyword argument 'target_cfg'
Failed to start WebSockets proxy

WebSocketServer does not have any references to target_cfg.

@DirectXMan12 DirectXMan12 added bug Something isn't working python labels Apr 9, 2015
@DirectXMan12 DirectXMan12 self-assigned this Apr 9, 2015
DirectXMan12 added a commit that referenced this issue Apr 9, 2015
Previously, if no `target_cfg` flag was used, the `target_cfg` option
would not get removed from the opts dict, causing an error when it got
passed through to `WebSocketProxy`.  Now we always remove it.

Fixes #168.
DirectXMan12 added a commit that referenced this issue Apr 9, 2015
Previously, if no `target_cfg` flag was used, the `target_cfg` option
would not get removed from the opts dict, causing an error when it got
passed through to `WebSocketProxy`.  Now we always remove it.

Fixes #168.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants