Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to change the channel on which requests will be emitted. #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shanielh
Copy link

@shanielh shanielh commented Oct 1, 2014

Hi.

I've added a patch that allows the model to describe the channel on which the requests will be emitted, Added two tests.

For example :

var model = new Backbone.Model();
model.channel = function(params) { return params.url; };
model.fetch({url: '/one/two'});
assert.equal(Backbone.socket.path, '/one/two:read');

Seems to work fine.

Allows the model to describe the channel on which the requests will be
emitted.
@mahnunchik
Copy link
Contributor

@shanielh Hi,
I do not see benefits of using the channel instead standart url.
Could you please clarify the use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants