Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix few typos and grammar #17

Merged
merged 15 commits into from
Dec 30, 2022
Merged

Fix few typos and grammar #17

merged 15 commits into from
Dec 30, 2022

Conversation

zakiego
Copy link
Contributor

@zakiego zakiego commented Dec 29, 2022

No description provided.

@zakiego
Copy link
Contributor Author

zakiego commented Dec 29, 2022

image

https://dasarpemrogramanrust.novalagung.com/basic/path-item#-stdstringstringnew

Is it "create" or should it be "crate"?

@zakiego zakiego marked this pull request as ready for review December 29, 2022 06:51
Copy link
Owner

@novalagung novalagung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall the typo fixes are good. really appreciate the PR @zakiego.

there is only one small issue, the changes to the /CONTRIBUTING URL path will break the generated build. Kindly please address that, thanks!

README.md Outdated Show resolved Hide resolved
@novalagung
Copy link
Owner

Is it "create" or should it be "crate"?

it should be crate

@novalagung novalagung mentioned this pull request Dec 29, 2022
@zakiego zakiego requested a review from novalagung December 29, 2022 23:18
Copy link
Owner

@novalagung novalagung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks!

@novalagung novalagung merged commit 0c35ee8 into novalagung:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants