Merge pull request #14 from ComposableFi/feat/wasm-clients-merge-02-r…

…efactor

merge 02 client refactor

.github/CODEOWNERS

@@ -1,6 +1,8 @@
 # CODEOWNERS: https://help.github.com/articles/about-codeowners/
 
-*       @colin-axner @AdityaSripal @crodriguezvega @seantking @charleenfei @damiannolan @chatton
+*       @colin-axner @AdityaSripal @crodriguezvega @charleenfei @damiannolan @chatton
+
+# Our appreciation and gratitude to past code owners: @fedekunze @seantking 
 
 # Order is important; the last matching pattern takes the most
 # precedence. When someone opens a pull request that only
@@ -9,34 +11,32 @@
 
 # CODEOWNERS for the CODEOWNER file
 
-/.github/CODEOWNERS @colin-axner @AdityaSripal @crodriguezvega
+/.github/CODEOWNERS @colin-axner @AdityaSripal @crodriguezvega @damiannolan
 
 # CODEOWNERS for the core IBC module
 
-/modules/core/ @colin-axner @AdityaSripal 
-/proto/ibc/core/ @colin-axner @AdityaSripal 
-
-## CODEOWNERS for core/02-client
-
-/modules/core/02-client @colin-axner @AdityaSripal @seantking @damiannolan
-/proto/ibc/core/client @colin-axner @AdityaSripal @seantking @damiannolan
+/modules/core/ @colin-axner @AdityaSripal @damiannolan
+/proto/ibc/core/ @colin-axner @AdityaSripal @damiannolan
 
 # CODEOWNERS for the light-clients
 
-/modules/light-clients/ @colin-axner @AdityaSripal @seantking @damiannolan
-/proto/ibc/lightclients/ @colin-axner @AdityaSripal @seantking @damiannolan
+/modules/light-clients/ @colin-axner @AdityaSripal @damiannolan
+/proto/ibc/lightclients/ @colin-axner @AdityaSripal @damiannolan
 
 # CODEOWNERS for ICS 20
 
-/modules/apps/transfer/ @colin-axner @AdityaSripal 
-/proto/ibc/applications/transfer/ @colin-axner @AdityaSripal 
+/modules/apps/transfer/ @colin-axner @AdityaSripal @damiannolan
+/proto/ibc/applications/transfer/ @colin-axner @AdityaSripal @damiannolan
 
 # CODEOWNERS for interchain-accounts module
 
-/modules/apps/27-interchain-accounts/ @seantking @colin-axner @AdityaSripal @damiannolan
-/proto/ibc/applications/interchain_accounts/ @seantking @colin-axner @AdityaSripal @damiannolan
+/modules/apps/27-interchain-accounts/ @colin-axner @AdityaSripal @damiannolan
+/proto/ibc/applications/interchain_accounts/ @colin-axner @AdityaSripal @damiannolan
 
 # CODEOWNERS for fee module
 
-/modules/apps/29-fee/ @AdityaSripal @seantking @charleenfei @colin-axner @damiannolan 
-/proto/ibc/applications/fee/ @AdityaSripal @seantking @charleenfei @colin-axner @damiannolan
+/modules/apps/29-fee/ @AdityaSripal @charleenfei @colin-axner @damiannolan 
+/proto/ibc/applications/fee/ @AdityaSripal @charleenfei @colin-axner @damiannolan
+
+# CODEOWNERS for docs
+/docs/ @colin-axner @AdityaSripal @crodriguezvega @charleenfei @damiannolan @chatton @tmsdkeys

.github/ISSUE_TEMPLATE/release-tracker.md

@@ -26,10 +26,11 @@ v                     without deliberation
 <!-- List of tests that need be performed with previous
 versions of ibc-go to guarantee that no regression is introduced -->
 
-- [ ] Fungible token transfers over a non-incentivised channel works with a counterparty chain running each previous major version.
-- [ ] Fungible token transfers over an incentivised channel works with a counterparty chain running each previous major version that supports ICS-29 Fee Middleware.
-- [ ] Interchain Accounts over a non-incentivised channel works with a counterparty chain running each previous major version that supports ICS-27 Interchain Accounts over non-incentivised channels.
-- [ ] Interchain Accounts over an incentivised channel works with a counterparty chain running each previous major version that supports ICS-27 Interchain Accounts over incentivised channels.
+- [ ] [Compatibility tests](https://github.com/cosmos/ibc-go/actions/workflows/e2e-compatibility.yaml) pass for the release branch.
+- [ ] [Upgrade tests](https://github.com/cosmos/ibc-go/actions/workflows/e2e-upgrade.yaml) pass.
+- [ ] [Interchain Accounts inter-tx tests](https://github.com/cosmos/interchain-accounts-demo/actions/workflows/e2e-compatibility.yaml) pass.
+
+### Other testing
 
 ## Migration 
 
@@ -41,7 +42,7 @@ versions of ibc-go to guarantee that no regression is introduced -->
 
 - [ ] Bump [go package version](https://github.com/cosmos/ibc-go/blob/main/go.mod#L3).
 - [ ] Change all imports starting with `github.com/cosmos/ibc-go/v{x}` to `github.com/cosmos/ibc-go/v{x+1}`.
-- [ ] Branch off main to create release branch in the form  of `release/vx.y.z`.
+- [ ] Branch off main to create release branch in the form  of `release/vx.y.z` and add branch protection rules.
 - [ ] Add branch protection rules to new release branch.
 - [ ] Add backport task to [`mergify.yml`](https://github.com/cosmos/ibc-go/blob/main/.github/mergify.yml)
 - [ ] Upgrade ibc-go version in [ibctest](https://github.com/strangelove-ventures/ibctest).
@@ -50,12 +51,25 @@ versions of ibc-go to guarantee that no regression is introduced -->
 ## Post-release checklist
 
 - [ ] Update [`CHANGELOG.md`](https://github.com/cosmos/ibc-go/blob/main/CHANGELOG.md)
-- [ ] Update the table of supported release lines (and End of Life dates) in [`RELEASES.md`](https://github.com/cosmos/ibc-go/blob/main/RELEASES.md).
-- [ ] Update [version matrix](https://github.com/cosmos/ibc-go/blob/main/RELEASES.md#version-matrix) in `RELEASES.md`.
+- [ ] Update the table of supported release lines (and End of Life dates) in [`RELEASES.md`](https://github.com/cosmos/ibc-go/blob/main/RELEASES.md):
+  - Add the new release line.
+  - Remove any release lines that might have become discontinued.
+- [ ] Update [version matrix](https://github.com/cosmos/ibc-go/blob/main/RELEASES.md#version-matrix) in `RELEASES.md`:
+  - Add the new release.
+  - Remove any tags that might not be recommended anymore.
+- [ ] Update the list of [supported release lines in README.md](https://github.com/cosmos/ibc-go#releases), if necessary.
 - [ ] Update docs site:
   - [ ] Add new release branch to [`docs/versions`](https://github.com/cosmos/ibc-go/blob/main/docs/versions) file.
-  - [ ] Add `label` and `key` to `versions` array in [`config.js`](https://github.com/cosmos/ibc-go/blob/main/docs/.vuepress/config.js#L33).
+  - [ ] Add `label` and `key` to `versions` array in [`config.js`](https://github.com/cosmos/ibc-go/blob/main/docs/.vuepress/config.js#L62).
+- [ ] Bump ibc-go version in [cosmos/interchain-accounts-demo repository](https://github.com/cosmos/interchain-accounts-demo) and create a tag.
+- [ ] Update the [compatibility test matrices](https://github.com/cosmos/ibc-go/tree/main/.github/compatibility-test-matrices):
+  - Add the new release.
+  - Remove any tags that might not be recommended anymore.
+- [ ] Update the manual [e2e `simd`](https://github.com/cosmos/ibc-go/blob/main/.github/workflows/e2e-manual-simd.yaml) and [e2e `icad`](https://github.com/cosmos/ibc-go/blob/main/.github/workflows/e2e-manual-icad.yaml) test workflows:
+  - Add the new release and the new `icad` tag.
+  - Remove any tags that might not be recommended anymore.
 - [ ] After changes to docs site are deployed, check [ibc.cosmos.network](https://ibc.cosmos.network) is updated.
+- [ ] Open issue in [SDK tutorials repo](https://github.com/cosmos/sdk-tutorials) to update tutorials to the released version of ibc-go.
 
 ____
 

.github/PULL_REQUEST_TEMPLATE.md

@@ -12,18 +12,41 @@ are the most critical to review.
 
 closes: #XXXX
 
+
+### Commit Message / Changelog Entry
+
+```bash
+type: commit message
+```
+
+see the [guidelines](https://github.com/cosmos/ibc-go/blob/main/CONTRIBUTING.md#commit-messages) for commit messages. (view raw markdown for examples)
+
+
+<!--
+Example commit messages:
+
+fix: skip emission of unpopulated memo field in ics20
+deps: updating sdk to v0.46.4
+chore: removed unused variables
+e2e: adding e2e upgrade test for ibc-go/v6
+docs: ics27 v6 documentation updates
+feat: add semantic version utilities for e2e tests
+feat(api)!: this is an api breaking feature
+fix(statemachine)!: this is a statemachine breaking fix
+-->
+
 ---
 
 Before we can merge this PR, please make sure that all the following items have been
 checked off. If any of the checklist items are not applicable, please leave them but
 write a little note why.
 
-- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
+- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)).
 - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
-- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
-- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
-- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
+- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/10-structure.md) and [Go style guide](../docs/dev/go-style-guide.md).
+- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing).
+- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`).
 - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
-- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
-- [ ] Re-reviewed `Files changed` in the Github PR explorer
-- [ ] Review `Codecov Report` in the comment section below once CI passes
+- [ ] Provide a [commit message](https://github.com/cosmos/ibc-go/blob/main/CONTRIBUTING.md#commit-messages) to be used for the changelog entry in the PR description for review.
+- [ ] Re-reviewed `Files changed` in the Github PR explorer.
+- [ ] Review `Codecov Report` in the comment section below once CI passes.

.github/compatibility-test-matrices/main/client-chain-a.json

@@ -0,0 +1,10 @@
+{
+  "chain-a": ["main"],
+  "chain-b": ["main", "v5.1.0", "v5.0.1", "v4.2.0", "v4.1.1", "v3.4.0", "v3.3.1", "v2.5.0", "v2.4.2"],
+  "entrypoint": ["TestClientTestSuite"],
+  "test": [
+    "TestClientUpdateProposal_Succeeds"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/main/client-chain-b.json

@@ -0,0 +1,10 @@
+{
+  "chain-a": ["main", "v5.1.0", "v5.0.1", "v4.2.0", "v4.1.1", "v3.4.0", "v3.3.1", "v2.5.0", "v2.4.2"],
+  "chain-b": ["main"],
+  "entrypoint": ["TestClientTestSuite"],
+  "test": [
+    "TestClientUpdateProposal_Succeeds"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/main/connection-chain-a.json

@@ -0,0 +1,10 @@
+{
+  "chain-a": ["main"],
+  "chain-b": ["main", "v5.1.0", "v5.0.1", "v4.2.0", "v4.1.1", "v3.4.0", "v3.3.1", "v2.5.0", "v2.4.2"],
+  "entrypoint": ["TestConnectionTestSuite"],
+  "test": [
+    "TestMaxExpectedTimePerBlockParam"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/main/connection-chain-b.json

@@ -0,0 +1,10 @@
+{
+  "chain-a": ["main", "v5.1.0", "v5.0.1", "v4.2.0", "v4.1.1", "v3.4.0", "v3.3.1", "v2.5.0", "v2.4.2"],
+  "chain-b": ["main"],
+  "entrypoint": ["TestConnectionTestSuite"],
+  "test": [
+    "TestMaxExpectedTimePerBlockParam"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/main/ica-chain-a.json

@@ -0,0 +1,12 @@
+{
+  "chain-a": ["main"],
+  "chain-b": ["main"],
+  "entrypoint": ["TestInterchainAccountsTestSuite"],
+  "test": [
+    "TestMsgSendTx_SuccessfulTransfer",
+    "TestMsgSendTx_FailedTransfer_InsufficientFunds",
+    "TestMsgSubmitTx_SuccessfulTransfer_AfterReopeningICA"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/main/ica-gov-chain-a.json

@@ -0,0 +1,10 @@
+{
+  "chain-a": ["main"],
+  "chain-b": ["main"],
+  "entrypoint": ["TestInterchainAccountsGovTestSuite"],
+  "test": [
+    "TestInterchainAccountsGovIntegration"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/main/ica-groups-chain-a.json

@@ -0,0 +1,10 @@
+{
+  "chain-a": ["main"],
+  "chain-b": ["main"],
+  "entrypoint": ["TestInterchainAccountsGroupsTestSuite"],
+  "test": [
+    "TestInterchainAccountsGroupsIntegration"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/main/incentivized-ica-chain-a.json

@@ -0,0 +1,11 @@
+{
+  "chain-a": ["main"],
+  "chain-b": ["main"],
+  "entrypoint": ["TestIncentivizedInterchainAccountsTestSuite"],
+  "test": [
+    "TestMsgSendTx_SuccessfulBankSend_Incentivized",
+    "TestMsgSendTx_FailedBankSend_Incentivized"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/main/incentivized-transfer-chain-a.json

@@ -0,0 +1,15 @@
+{
+  "chain-a": ["main"],
+  "chain-b": ["main", "v5.1.0", "v5.0.1", "v4.2.0", "v4.1.1"],
+  "entrypoint": ["TestIncentivizedTransferTestSuite"],
+  "test": [
+    "TestMsgPayPacketFee_AsyncSingleSender_Succeeds",
+    "TestMsgPayPacketFee_InvalidReceiverAccount",
+    "TestMultiMsg_MsgPayPacketFeeSingleSender",
+    "TestMsgPayPacketFee_SingleSender_TimesOut",
+    "TestPayPacketFeeAsync_SingleSender_NoCounterPartyAddress",
+    "TestMsgPayPacketFee_AsyncMultipleSenders_Succeeds"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/main/incentivized-transfer-chain-b.json

@@ -0,0 +1,15 @@
+{
+  "chain-a": ["main", "v5.1.0", "v5.0.1", "v4.2.0", "v4.1.1"],
+  "chain-b": ["main"],
+  "entrypoint": ["TestIncentivizedTransferTestSuite"],
+  "test": [
+    "TestMsgPayPacketFee_AsyncSingleSender_Succeeds",
+    "TestMsgPayPacketFee_InvalidReceiverAccount",
+    "TestMultiMsg_MsgPayPacketFeeSingleSender",
+    "TestMsgPayPacketFee_SingleSender_TimesOut",
+    "TestPayPacketFeeAsync_SingleSender_NoCounterPartyAddress",
+    "TestMsgPayPacketFee_AsyncMultipleSenders_Succeeds"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/main/transfer-chain-a.json

@@ -0,0 +1,15 @@
+{
+  "chain-a": ["main"],
+  "chain-b": ["main", "v5.1.0", "v5.0.1", "v4.2.0", "v4.1.1", "v3.4.0", "v3.3.1", "v2.5.0", "v2.4.2"],
+  "entrypoint": ["TestTransferTestSuite"],
+  "test": [
+    "TestMsgTransfer_Succeeds_Nonincentivized",
+    "TestMsgTransfer_Fails_InvalidAddress",
+    "TestMsgTransfer_Timeout_Nonincentivized",
+    "TestMsgTransfer_WithMemo",
+    "TestSendEnabledParam",
+    "TestReceiveEnabledParam"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/main/transfer-chain-b.json

@@ -0,0 +1,15 @@
+{
+  "chain-a": ["main", "v5.1.0", "v5.0.1", "v4.2.0", "v4.1.1", "v3.4.0", "v3.3.1", "v2.5.0", "v2.4.2"],
+  "chain-b": ["main"],
+  "entrypoint": ["TestTransferTestSuite"],
+  "test": [
+    "TestMsgTransfer_Succeeds_Nonincentivized",
+    "TestMsgTransfer_Fails_InvalidAddress",
+    "TestMsgTransfer_Timeout_Nonincentivized",
+    "TestMsgTransfer_WithMemo",
+    "TestSendEnabledParam",
+    "TestReceiveEnabledParam"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/release-v2.5.x/transfer-chain-a.json

@@ -0,0 +1,15 @@
+{
+  "chain-a": ["release-v2.5.x"],
+  "chain-b": ["release-v2.5.x", "v6.1.0", "v5.2.0", "v4.2.0", "v4.1.1", "v3.4.0", "v3.3.1", "v2.5.0", "v2.4.2"],
+  "entrypoint": ["TestTransferTestSuite"],
+  "test": [
+    "TestMsgTransfer_Succeeds_Nonincentivized",
+    "TestMsgTransfer_Fails_InvalidAddress",
+    "TestMsgTransfer_Timeout_Nonincentivized",
+    "TestMsgTransfer_WithMemo",
+    "TestSendEnabledParam",
+    "TestReceiveEnabledParam"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/release-v2.5.x/transfer-chain-b.json

@@ -0,0 +1,15 @@
+{
+  "chain-a": ["release-v2.5.x", "v6.1.0", "v5.2.0", "v4.2.0", "v4.1.1", "v3.4.0", "v3.3.1", "v2.5.0", "v2.4.2"],
+  "chain-b": ["release-v2.5.x"],
+  "entrypoint": ["TestTransferTestSuite"],
+  "test": [
+    "TestMsgTransfer_Succeeds_Nonincentivized",
+    "TestMsgTransfer_Fails_InvalidAddress",
+    "TestMsgTransfer_Timeout_Nonincentivized",
+    "TestMsgTransfer_WithMemo",
+    "TestSendEnabledParam",
+    "TestReceiveEnabledParam"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/release-v3.4.x/transfer-chain-a.json

@@ -0,0 +1,15 @@
+{
+  "chain-a": ["release-v3.4.x"],
+  "chain-b": ["release-v3.4.x", "v6.1.0", "v5.2.0", "v4.2.0", "v4.1.1", "v3.4.0", "v3.3.1", "v2.5.0", "v2.4.2"],
+  "entrypoint": ["TestTransferTestSuite"],
+  "test": [
+    "TestMsgTransfer_Succeeds_Nonincentivized",
+    "TestMsgTransfer_Fails_InvalidAddress",
+    "TestMsgTransfer_Timeout_Nonincentivized",
+    "TestMsgTransfer_WithMemo",
+    "TestSendEnabledParam",
+    "TestReceiveEnabledParam"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/release-v3.4.x/transfer-chain-b.json

@@ -0,0 +1,15 @@
+{
+  "chain-a": ["release-v3.4.x", "v6.1.0", "v5.2.0", "v4.2.0", "v4.1.1", "v3.4.0", "v3.3.1", "v2.5.0", "v2.4.2"],
+  "chain-b": ["release-v3.4.x"],
+  "entrypoint": ["TestTransferTestSuite"],
+  "test": [
+    "TestMsgTransfer_Succeeds_Nonincentivized",
+    "TestMsgTransfer_Fails_InvalidAddress",
+    "TestMsgTransfer_Timeout_Nonincentivized",
+    "TestMsgTransfer_WithMemo",
+    "TestSendEnabledParam",
+    "TestReceiveEnabledParam"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}

.github/compatibility-test-matrices/release-v4.2.x/incentivized-transfer-chain-a.json

@@ -0,0 +1,15 @@
+{
+  "chain-a": ["release-v4.2.x"],
+  "chain-b": ["release-v4.2.x", "v6.1.0", "v5.2.0", "v4.1.1"],
+  "entrypoint": ["TestIncentivizedTransferTestSuite"],
+  "test": [
+    "TestMsgPayPacketFee_AsyncSingleSender_Succeeds",
+    "TestMsgPayPacketFee_InvalidReceiverAccount",
+    "TestMultiMsg_MsgPayPacketFeeSingleSender",
+    "TestMsgPayPacketFee_SingleSender_TimesOut",
+    "TestPayPacketFeeAsync_SingleSender_NoCounterPartyAddress",
+    "TestMsgPayPacketFee_AsyncMultipleSenders_Succeeds"
+  ],
+  "chain-binary": ["simd"],
+  "chain-image": ["ghcr.io/cosmos/ibc-go-simd"]
+}