Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change feeabs design from IBC baseapp module to IBC middleware module #55

Open
GNaD13 opened this issue Jan 31, 2023 · 3 comments
Open
Labels
discussion Need to discussion about detail of this issue

Comments

@GNaD13
Copy link
Contributor

GNaD13 commented Jan 31, 2023

Currently, we face a issue that if the swap method trigger timeout, we IBC transfer will handle the timeout logic. It mean feeabs will not recognize it.

@GNaD13 GNaD13 added the discussion Need to discussion about detail of this issue label Jan 31, 2023
@GNaD13
Copy link
Contributor Author

GNaD13 commented Jan 31, 2023

@vuong177 @catShaark @hieuvubk I think we need to refactor all current design, need a discussion here

@GNaD13
Copy link
Contributor Author

GNaD13 commented Jan 31, 2023

So if change to use ibc middleware, we must handle All Ibc packet because they use same connection (transfer) which is not gonna work because these 2 ibc msg must be in different connection (swap work via transfer but query spot price not)
=> I think we must separate these 2 msg to 2 different module

@GNaD13
Copy link
Contributor Author

GNaD13 commented Jan 31, 2023

So if change to use ibc middleware, we must handle All Ibc packet because they use same connection (transfer) which is not gonna work because these 2 ibc msg must be in different connection (swap work via transfer but query spot price not) => I think we must separate these 2 msg to 2 different module

Oh, I think we still can use these 2 msg in the same module :3

tuantran1702 pushed a commit that referenced this issue Mar 4, 2024
* install the cosmic condom

* update interchaintest

* update interchaintest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Need to discussion about detail of this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant