EventLoop::new: Use level-triggered events for inotify fd. (backport to v4) #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `inotify` crate's `Inotify::read_events` method does not read all available events from inotify (see hannobraun/inotify-rs#156), only one buffer's worth. Using level-triggered events tells Mio to report events on the inotify fd until all events have been read. Fixes notify-rs#267.
jimblandy
force-pushed
the
level-trigger-v4
branch
from
3389a1e to
8d2706a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #268, rebased onto v4.0.15.
The
inotifycrate'sInotify::read_eventsmethod does not read all availableevents from inotify (see hannobraun/inotify-rs#156), only one buffer's worth. Using
level-triggered events tells Mio to report events on the inotify fd until all
events have been read.
Fixes #267.