Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i1042 Fall back on default work type when model is empty #1043

Conversation

bkiahstroud
Copy link
Contributor

Story

Ref

Importing a CSV without a model column leads to the importer failing to run and logging this error: NameError - uninitialized constant Hyrax::Form Did you mean? Hyrax::Forms.

CSVs imported without a model column should fallback on Bulkrax.default_work_type.

@bkiahstroud bkiahstroud requested a review from kirkkwang June 29, 2024 04:16
Copy link
Contributor

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bkiahstroud bkiahstroud merged commit c8e5438 into main Jun 29, 2024
6 checks passed
@bkiahstroud bkiahstroud deleted the i1042-bulkrax-empty-model-falls-back-on-default-work-type-as-intended branch June 29, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants