♿️ Don't render an empty breadcrumb element #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjproctor
approved these changes
Sep 6, 2024
kirkkwang
changed the title
This commit will guard against rendering an empty breadcrumb element when there are no breadcrumbs to display. The check we are doing is to see if the html string has the `breadcrumb-item` class. Ref: - #67
kirkkwang
force-pushed
the
i67-empty-breadcrumbs
branch
from
e4a2247 to
eb9a930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will guard against rendering an empty breadcrumb element when there are no breadcrumbs to display. The check we are doing is to see if the html string has the
breadcrumb-itemclass.Ref:
Before:
After:
