-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CMS content type check #35
fix: CMS content type check #35
Conversation
Signed-off-by: Junjie Gao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
- Coverage 95.24% 94.52% -0.72%
==========================================
Files 19 19
Lines 736 932 +196
==========================================
+ Hits 701 881 +180
- Misses 18 34 +16
Partials 17 17 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Previously, the CMS package was generically designed for RFC 5652. However, since the CMS package will not be exported and we only need to care about RFC 3161, we can restrict the CMS content type to TSTInfo (id-ct-TSTInfo) to fail fast.
Which issue(s) this PR resolves (optional, in
resolves #<issue number>(, resolves #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Resolves #33
Please check the following list: