-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User Story] - Notation sign/verify Tag to Digest translation #61
Comments
@SteveLasker - This is the one we were thinking of pushing out of RC-1. |
Migrate to notaryproject/notation#194 |
|
@gokarnm - Could you capture your concern about including "tag to digest" capability with our without the "force" flag as described above by @SteveLasker . Are you recommending we not include this capability at all for RC-1 ? Could you point out the threat model here if we ship with this capability here? |
@iamsamirzon Closing since this is now on the RC-1 roadmap - issue linked above. |
@dtzar - I suggest we reopen it and close it after the actual work is completed in Notation. |
Reopening until we potentially land on something other than roadmap. |
Thanks @dtzar - I have moved it back in the "To do" column in the project board. |
We need to define the CLI Spec to ensure the experience is agreed on what users will have to do. |
@iamsamirzon @gokarnm @yizha1 - Per what Steve says above, I'm still unsure of what is missing in implementation since today as I understand it - if you specify a tag, we translate it and sign a digest. As a related side note I do believe we need to have a better experience than spitting out the SHA/digest after a sign/verify so they have more details as to what they're signing - but this is a separate concern. |
@dtzar - What's missing is the agreed on spec on what we want as the behavior for translation from tag to digest translation. If we agree on the spec, and then the current implementation matches the spec we agree to, then we can say no work is required As an example, if at some point, we want to natively support "Tag signing" ( Refer #16 and notaryproject/specifications#43) , then we can't go back and change the behavior we agree here for this roadmap item. |
Per community call today, converting this to implementing the UX experiences so people understand what it is that they signed or verified. We already today do the tag to digest translation for sign and verify. However, people have no confirmation of what they signed or verified with what certificate(s). We also need to do a pass on the documentation to ensure this is properly reflected. |
Closed as completed |
As a signer or verifier, I want to specify a tag and ensure there is a translation to the digest so that I can properly sign and verify images.
Original text:
Desire : To help scenarios where users want to sign with Tag, but base Notation only supports digest signing, this wrapper layer will bridge the gap.
Outcome : A reference implementation in Notation that allows users to pass a tag ( with a --force flag) that clearly articulates that is not a recommended approach. For signing, Notation should return the digest it signed and not the tag the user passed.
The text was updated successfully, but these errors were encountered: