Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Story] - Notation sign/verify Tag to Digest translation #61

Closed
4 of 5 tasks
iamsamirzon opened this issue Mar 3, 2022 · 13 comments
Closed
4 of 5 tasks

[User Story] - Notation sign/verify Tag to Digest translation #61

iamsamirzon opened this issue Mar 3, 2022 · 13 comments
Assignees
Labels
enhancement New feature or request epic new work which requires one or more features, tasks, or issues to complete. triage Issues for which we need to revisit the right release timeline User Story
Milestone

Comments

@iamsamirzon
Copy link
Contributor

iamsamirzon commented Mar 3, 2022

As a signer or verifier, I want to specify a tag and ensure there is a translation to the digest so that I can properly sign and verify images.

Original text:
Desire : To help scenarios where users want to sign with Tag, but base Notation only supports digest signing, this wrapper layer will bridge the gap.
Outcome : A reference implementation in Notation that allows users to pass a tag ( with a --force flag) that clearly articulates that is not a recommended approach. For signing, Notation should return the digest it signed and not the tag the user passed.

@iamsamirzon iamsamirzon added this to the RC-1 milestone Mar 3, 2022
@iamsamirzon iamsamirzon modified the milestones: RC-1, RC-2 Mar 3, 2022
@iamsamirzon
Copy link
Contributor Author

@SteveLasker - This is the one we were thinking of pushing out of RC-1.

@dtzar
Copy link
Contributor

dtzar commented Jun 8, 2022

Migrate to notaryproject/notation#194

@SteveLasker
Copy link
Contributor

notation sign registry.wabbitnetworks.io/net-monitor:v1 is already implemented to convert :v1 to a digest and sign the digest.
If the ask is to change the behavior to requiring a --force flag, I'm not sure what that really does to change the behavior.
If the step in the workflow only has a tag, how would the user get the digest for the tag? How is that any different than passing in the tag and having notation sign do the conversion?
From a doc perspective, we could, and should show notation sign registry.wabbitnetworks.io/net-monitor@sha256:abc123... so the users that have digests would be promoted to do so. Even the helper text for notation sign should emit the example. Just not sure I buy the value of --force.

@iamsamirzon
Copy link
Contributor Author

@gokarnm - Could you capture your concern about including "tag to digest" capability with our without the "force" flag as described above by @SteveLasker . Are you recommending we not include this capability at all for RC-1 ? Could you point out the threat model here if we ship with this capability here?

@dtzar
Copy link
Contributor

dtzar commented Jun 30, 2022

@iamsamirzon Closing since this is now on the RC-1 roadmap - issue linked above.

@iamsamirzon
Copy link
Contributor Author

@dtzar - I suggest we reopen it and close it after the actual work is completed in Notation.

@dtzar
Copy link
Contributor

dtzar commented Jul 12, 2022

Reopening until we potentially land on something other than roadmap.
notaryproject/specifications#104

@dtzar dtzar reopened this Jul 12, 2022
Repository owner moved this from Done to In Progress in Notary Project Planning Board Jul 12, 2022
@iamsamirzon
Copy link
Contributor Author

Thanks @dtzar - I have moved it back in the "To do" column in the project board.

@iamsamirzon iamsamirzon added the triage Issues for which we need to revisit the right release timeline label Jul 14, 2022
@iamsamirzon iamsamirzon modified the milestones: RC-1, Discuss Jul 14, 2022
@iamsamirzon
Copy link
Contributor Author

We need to define the CLI Spec to ensure the experience is agreed on what users will have to do.

@dtzar dtzar added User Story epic new work which requires one or more features, tasks, or issues to complete. labels Aug 1, 2022
@dtzar dtzar changed the title Notation CLI to support Tag to Digest translation for signing and Verification [User Story] - Notation sign/verify Tag to Digest translation Aug 1, 2022
@dtzar
Copy link
Contributor

dtzar commented Aug 3, 2022

@iamsamirzon @gokarnm @yizha1 - Per what Steve says above, I'm still unsure of what is missing in implementation since today as I understand it - if you specify a tag, we translate it and sign a digest.

As a related side note I do believe we need to have a better experience than spitting out the SHA/digest after a sign/verify so they have more details as to what they're signing - but this is a separate concern.

@iamsamirzon
Copy link
Contributor Author

@dtzar - What's missing is the agreed on spec on what we want as the behavior for translation from tag to digest translation. If we agree on the spec, and then the current implementation matches the spec we agree to, then we can say no work is required

As an example, if at some point, we want to natively support "Tag signing" ( Refer #16 and notaryproject/specifications#43) , then we can't go back and change the behavior we agree here for this roadmap item.

@dtzar
Copy link
Contributor

dtzar commented Oct 13, 2022

Per community call today, converting this to implementing the UX experiences so people understand what it is that they signed or verified. We already today do the tag to digest translation for sign and verify. However, people have no confirmation of what they signed or verified with what certificate(s).

We also need to do a pass on the documentation to ensure this is properly reflected.

@yizha1 yizha1 self-assigned this Oct 17, 2022
@yizha1 yizha1 moved this from In Progress to PR Review in Notary Project Planning Board Nov 8, 2022
@yizha1
Copy link
Contributor

yizha1 commented Dec 5, 2022

Closed as completed

@yizha1 yizha1 closed this as completed Dec 5, 2022
Repository owner moved this from PR Review to Done in Notary Project Planning Board Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic new work which requires one or more features, tasks, or issues to complete. triage Issues for which we need to revisit the right release timeline User Story
Projects
Status: Done
Development

No branches or pull requests

4 participants