Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct broken link to quick start guide #831

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

rcrozean
Copy link
Contributor

Similarly to notaryproject/notaryproject.dev#360,
I attempted to follow the link in the README.md for the quick start guide and discovered the broken link. Linking to the official page.

URL: https://notaryproject.dev/docs/quickstart/
Expected page: https://notaryproject.dev/docs/quickstart-guides/quickstart-sign-image-artifact/

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8aab15) 64.05% compared to head (a1c4812) 64.05%.
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #831   +/-   ##
=======================================
  Coverage   64.05%   64.05%           
=======================================
  Files          40       40           
  Lines        2323     2323           
=======================================
  Hits         1488     1488           
  Misses        709      709           
  Partials      126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi
Copy link
Contributor

@rcrozean rcrozean force-pushed the correctQuickstartLink branch from 4a59209 to cbfe69e Compare November 21, 2023 22:54
@rcrozean rcrozean force-pushed the correctQuickstartLink branch from cbfe69e to a1c4812 Compare November 21, 2023 22:57
@rcrozean
Copy link
Contributor Author

Commit signed!

@priteshbandi priteshbandi merged commit 4569f3f into notaryproject:main Nov 22, 2023
5 checks passed
Two-Hearts pushed a commit to Two-Hearts/notation that referenced this pull request Dec 14, 2023
Similarly to notaryproject/notaryproject.dev#360,
I attempted to follow the link in the README.md for the quick start guide and discovered the broken link. Linking to the official page.

URL: https://notaryproject.dev/docs/quickstart/
Expected page: https://notaryproject.dev/docs/quickstart-guides/quickstart-sign-image-artifact/

Signed-off-by: Cameron Rozean <[email protected]>
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
Similarly to notaryproject/notaryproject.dev#360,
I attempted to follow the link in the README.md for the quick start guide and discovered the broken link. Linking to the official page.

URL: https://notaryproject.dev/docs/quickstart/
Expected page: https://notaryproject.dev/docs/quickstart-guides/quickstart-sign-image-artifact/

Signed-off-by: Cameron Rozean <[email protected]>
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
Similarly to notaryproject/notaryproject.dev#360,
I attempted to follow the link in the README.md for the quick start guide and discovered the broken link. Linking to the official page.

URL: https://notaryproject.dev/docs/quickstart/
Expected page: https://notaryproject.dev/docs/quickstart-guides/quickstart-sign-image-artifact/

Signed-off-by: Cameron Rozean <[email protected]>
Signed-off-by: rgnote <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants