-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update README to align with the new brand name #750
Conversation
Signed-off-by: Feynman Zhou <[email protected]>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #750 +/- ##
=======================================
Coverage 63.98% 63.98%
=======================================
Files 40 40
Lines 2252 2252
=======================================
Hits 1441 1441
Misses 689 689
Partials 122 122 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FeynmanZhou left a few comments
Signed-off-by: Feynman Zhou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FeynmanZhou LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still comment to resolve, otherwise LGTM.
Signed-off-by: Feynman Zhou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
- [Quick start: Sign and validate a container image](https://notaryproject.dev/docs/quickstart/) | ||
- [Try Notation on an online playground](https://killercoda.com/notaryproject/scenario/notation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [Try Notation on an online playground](https://killercoda.com/notaryproject/scenario/notation) | |
- [Try out Notation in this Killercoda interactive sandbox environment](https://killercoda.com/notaryproject/scenario/notation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Added a minor edit.
Signed-off-by: Sajay Antony <[email protected]>
Addresses [the feedback](#750 (comment)) from #750 /cc @gokarnm Signed-off-by: Sajay Antony <[email protected]>
Resolve #715