Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OCI 1.1 support #1192

Merged
merged 4 commits into from
Feb 25, 2025
Merged

feat: OCI 1.1 support #1192

merged 4 commits into from
Feb 25, 2025

Conversation

Two-Hearts
Copy link
Contributor

In this PR:

  • removes the deprecated experimental flag --allow-referrers-api
  • updates the default value of flag --force-referrers-tag to false in sign command.

Resolves #1040

@Two-Hearts
oci 1.1
90b49fa 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
oci 1.1
630608a 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
oci 1.1
9b6693d 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix e2e
0e3e883 
Signed-off-by: Patrick Zheng <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.11%. Comparing base (db697f2) to head (0e3e883).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1192      +/-   ##
==========================================
- Coverage   76.29%   76.11%   -0.18%     
==========================================
  Files          69       69              
  Lines        3623     3596      -27     
==========================================
- Hits         2764     2737      -27     
  Misses        665      665              
  Partials      194      194

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Two-Hearts Two-Hearts mentioned this pull request Feb 25, 2025
Closed
shizhMSFT
shizhMSFT approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao reviewed Feb 25, 2025
View reviewed changes
@Two-Hearts Two-Hearts mentioned this pull request Feb 25, 2025
Open
JeyJeyGao
JeyJeyGao approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit ae0d432 into notaryproject:main Feb 25, 2025
7 checks passed
@Two-Hearts Two-Hearts deleted the oci branch February 25, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the default behavior to use the OCI-1.1 specification when storing signatures.
3 participants
@Two-Hearts @shizhMSFT @JeyJeyGao