Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: release v1.2.0 #1022

Merged
merged 1 commit into from
Aug 29, 2024
Merged

bump: release v1.2.0 #1022

merged 1 commit into from
Aug 29, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Aug 29, 2024 •
edited by rgnote
Loading

Release

This would mean tagging 4700ad6 as v1.2.0 to release.

Vote

We need at least 4 approvals from 6 maintainers to release notation v1.2.0.

What's Changed

Full Changelog: v1.2.0-rc.1...4700ad6

Actions

Please review the PR and vote by approving.

@Two-Hearts
bump: release v1.2.0
4700ad6 
Signed-off-by: Patrick Zheng <[email protected]>
@JeyJeyGao
Copy link
Contributor

LGTM

@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.01%. Comparing base (8ad226c) to head (4700ad6).
Report is 2 commits behind head on release-1.2.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-1.2    #1022   +/-   ##
============================================
  Coverage        72.01%   72.01%           
============================================
  Files               46       46           
  Lines             2287     2287           
============================================
  Hits              1647     1647           
  Misses             440      440           
  Partials           200      200

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JeyJeyGao
JeyJeyGao approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts
Copy link
Contributor Author

LGTM

1 similar comment
@priteshbandi
Copy link
Contributor

LGTM

shizhMSFT
shizhMSFT approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit e450002 into notaryproject:release-1.2 Aug 29, 2024
7 checks passed
@Two-Hearts Two-Hearts deleted the release-1.2 branch August 29, 2024 06:16
@Two-Hearts Two-Hearts mentioned this pull request Sep 9, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Two-Hearts @JeyJeyGao @priteshbandi @shizhMSFT