Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit #2

Merged
merged 9 commits into from
Dec 22, 2023
Merged

Initial commit #2

merged 9 commits into from
Dec 22, 2023

Conversation

priteshbandi
Copy link
Contributor

This is first code PR for this package and contains following changes

  1. Copied notation-go/plugin/proto related code to notation-plugin-framework-go/plugin. Will delete notation-go code in subsequent PRs
  2. Created new Cli package which provides boilerplate code required to generate plugin executable.
  3. example package contains and example plugin implementation (some documentation is missing but will add in subsequent PRs

Signed-off-by: Pritesh Bandi <[email protected]>
cli/cli.go Show resolved Hide resolved
@priteshbandi priteshbandi requested a review from JeyJeyGao August 16, 2023 16:56
plugin/proto.go Show resolved Hide resolved
log/log.go Show resolved Hide resolved
example/go.mod Outdated Show resolved Hide resolved
cli/cli_test.go Outdated Show resolved Hide resolved
cli/cli.go Outdated Show resolved Hide resolved
cli/cli.go Show resolved Hide resolved
cli/cli.go Show resolved Hide resolved
cli/utils.go Outdated Show resolved Hide resolved
cli/cli.go Outdated Show resolved Hide resolved
cli/cli.go Outdated Show resolved Hide resolved
priteshbandi and others added 2 commits August 18, 2023 17:39
Co-authored-by: Shiwei Zhang <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Co-authored-by: Shiwei Zhang <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
log/log.go Show resolved Hide resolved
log/log.go Show resolved Hide resolved
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Copy link

@rgnote rgnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

example/main.go Show resolved Hide resolved
example/go.mod Outdated Show resolved Hide resolved
plugin/algorithm.go Show resolved Hide resolved
Signed-off-by: Pritesh Bandi <[email protected]>
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priteshbandi could you help me understand better of the purpose of this repo again? (since this PR is just an initial one, it does not provide the whole picture of the repo.)
My understanding/questions:

  1. The current notation-go library already provides all the necessary functions/APIs. Is there anything that's blocking our users to use notation-go directly at the moment? (I guess this answers why we should have this new repo.)
  2. Which packages are you planning to move from notation-go? (I could see proto in this PR, anything else in your plan?)

/cc: @shizhMSFT @yizha1 @FeynmanZhou

cli/cli.go Show resolved Hide resolved
@priteshbandi
Copy link
Contributor Author

@Two-Hearts The library's objectives are as follows:

  1. Simplifying the implementation process for plugin developers by encapsulating all overarching concerns.
  2. Promoting a practice that enables plugin code to be utilized as a plugin library in notation-go, while also supporting the generation of executable.

The current notation-go library already provides all the necessary functions/APIs. Is there anything that's blocking our users to use notation-go directly at the moment? (I guess this answers why we should have this new repo.)

notation-go has lot of direct or indirect dependencies like oras-go, ldap, go-cose, jwt, etc. which plugin implementer don't need. When I think about dependency is unnecessary maintenance.

Which packages are you planning to move from notation-go? (I could see proto in this PR, anything else in your plan?)

I am planning to move Plugin Interface and its dependencies to this pkg. Basically all dependency required to use plugin as library.

@priteshbandi priteshbandi force-pushed the setup branch 3 times, most recently from d367efd to 4d0c714 Compare December 22, 2023 05:50
log/log.go Outdated Show resolved Hide resolved
log/log.go Outdated Show resolved Hide resolved
Signed-off-by: Pritesh Bandi <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for initial commits. We can improve others like license headers as well as license checkers in the next PRs.

@priteshbandi priteshbandi merged commit c8c68d2 into notaryproject:main Dec 22, 2023
1 check passed
@priteshbandi priteshbandi deleted the setup branch December 22, 2023 13:25
@priteshbandi priteshbandi mentioned this pull request Jan 29, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants