-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit #2
Conversation
Signed-off-by: Pritesh Bandi <[email protected]>
Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Pritesh Bandi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@priteshbandi could you help me understand better of the purpose
of this repo again? (since this PR is just an initial one, it does not provide the whole picture of the repo.)
My understanding/questions:
- The current notation-go library already provides all the necessary functions/APIs. Is there anything that's blocking our users to use notation-go directly at the moment? (I guess this answers why we should have this new repo.)
- Which packages are you planning to move from notation-go? (I could see
proto
in this PR, anything else in your plan?)
@Two-Hearts The library's objectives are as follows:
The current notation-go library already provides all the necessary functions/APIs. Is there anything that's blocking our users to use notation-go directly at the moment? (I guess this answers why we should have this new repo.)
Which packages are you planning to move from notation-go? (I could see proto in this PR, anything else in your plan?)
|
d367efd
to
4d0c714
Compare
Signed-off-by: Pritesh Bandi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for initial commits. We can improve others like license headers as well as license checkers in the next PRs.
This is first code PR for this package and contains following changes
notation-plugin-framework-go/plugin
. Will delete notation-go code in subsequent PRsexample
package contains and example plugin implementation (some documentation is missing but will add in subsequent PRs