Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: bump up notation-core-go and signingAgent #444

Merged
merged 3 commits into from
Sep 4, 2024
Merged

bump: bump up notation-core-go and signingAgent #444

merged 3 commits into from
Sep 4, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Aug 27, 2024 •
edited
Loading

This PR targets on main branch.

@Two-Hearts
bump up on main
65d08b9 
Signed-off-by: Patrick Zheng <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.86%. Comparing base (4403efa) to head (7267f89).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files          33       33           
  Lines        2483     2483           
=======================================
  Hits         2008     2008           
  Misses        332      332           
  Partials      143      143

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Two-Hearts
update
923e6c2 
Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
JeyJeyGao approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR succeeded by #442 ?

@Two-Hearts
Copy link
Contributor Author

Two-Hearts commented Aug 28, 2024 •
edited
Loading

Is this PR succeeded by #442 ?

No, this PR targets on main branch as shown at the top of the PR. Whereas, #442 targets at the release-1.2 branch. And the signingAgent has different values as well.

Updated the PR title to make it clearer.

@Two-Hearts Two-Hearts changed the title bump: bump up notation-core-go and signingAgent bump: bump up notation-core-go and signingAgent on main Aug 28, 2024
@Two-Hearts Two-Hearts requested a review from shizhMSFT August 28, 2024 02:00
@shizhMSFT shizhMSFT changed the title bump: bump up notation-core-go and signingAgent on main bump: bump up notation-core-go and signingAgent Aug 28, 2024
shizhMSFT
shizhMSFT approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts mentioned this pull request Sep 2, 2024
Closed
JeyJeyGao
JeyJeyGao approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vaninrao10
vaninrao10 approved these changes Sep 3, 2024
View reviewed changes
Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 115509e into notaryproject:main Sep 4, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the fix branch September 4, 2024 00:59
JasonTheDeveloper pushed a commit to JasonTheDeveloper/notation-go that referenced this pull request Sep 4, 2024
@Two-Hearts @JasonTheDeveloper
bump: bump up notation-core-go and signingAgent (notaryproject#444)
4913567 
This PR targets on main branch.

---------

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Jason <[email protected]>
JasonTheDeveloper pushed a commit to JasonTheDeveloper/notation-go that referenced this pull request Sep 4, 2024
@Two-Hearts @JasonTheDeveloper
bump: bump up notation-core-go and signingAgent (notaryproject#444)
7e26ba3 
This PR targets on main branch.

---------

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Jason <[email protected]>
JasonTheDeveloper pushed a commit to JasonTheDeveloper/notation-go that referenced this pull request Sep 4, 2024
@Two-Hearts @JasonTheDeveloper
bump: bump up notation-core-go and signingAgent (notaryproject#444)
05b532f 
This PR targets on main branch.

---------

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Jason <[email protected]>
JasonTheDeveloper pushed a commit to JasonTheDeveloper/notation-go that referenced this pull request Sep 4, 2024
@Two-Hearts @JasonTheDeveloper
bump: bump up notation-core-go and signingAgent (notaryproject#444)
f80db05 
This PR targets on main branch.

---------

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Jason <[email protected]>
JasonTheDeveloper pushed a commit to JasonTheDeveloper/notation-go that referenced this pull request Sep 4, 2024
@Two-Hearts @JasonTheDeveloper
bump: bump up notation-core-go and signingAgent (notaryproject#444)
5254eae 
This PR targets on main branch.

---------

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Jason <[email protected]>
JasonTheDeveloper pushed a commit to JasonTheDeveloper/notation-go that referenced this pull request Sep 4, 2024
@Two-Hearts @JasonTheDeveloper
bump: bump up notation-core-go and signingAgent (notaryproject#444)
115f64f 
This PR targets on main branch.

---------

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Jason <[email protected]>
JasonTheDeveloper pushed a commit to JasonTheDeveloper/notation-go that referenced this pull request Sep 4, 2024
@Two-Hearts @JasonTheDeveloper
bump: bump up notation-core-go and signingAgent (notaryproject#444)
ff67f65 
This PR targets on main branch.

---------

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Jason <[email protected]>
@Two-Hearts Two-Hearts mentioned this pull request Sep 27, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaninrao10 vaninrao10 vaninrao10 approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Two-Hearts @shizhMSFT @JeyJeyGao @vaninrao10