Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: bump up notation-core-go v1.0.3 #407

Merged

Conversation

JeyJeyGao
Copy link
Contributor

Signed-off-by: Junjie Gao [email protected]

@JeyJeyGao JeyJeyGao marked this pull request as ready for review May 29, 2024 05:37
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.17%. Comparing base (9ff1891) to head (af418c7).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   73.43%   80.17%   +6.74%     
==========================================
  Files          24       31       +7     
  Lines        2507     2174     -333     
==========================================
- Hits         1841     1743      -98     
+ Misses        526      302     -224     
+ Partials      140      129      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao JeyJeyGao changed the title bump: notation-core-go v1.0.3 bump: bump up notation-core-go v1.0.3 May 29, 2024
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 254dfcd into notaryproject:main May 29, 2024
9 checks passed
@JeyJeyGao JeyJeyGao deleted the bump/notation-core-go_v1.0.3 branch May 29, 2024 06:00
JeyJeyGao added a commit that referenced this pull request May 29, 2024
Signed-off-by: Junjie Gao <[email protected]>

Signed-off-by: Junjie Gao <[email protected]>
This was referenced May 29, 2024
@Two-Hearts Two-Hearts mentioned this pull request Jul 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants