Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: start using plugin-framework package #372

Merged
merged 14 commits into from
Feb 1, 2024
Merged

chore: start using plugin-framework package #372

merged 14 commits into from
Feb 1, 2024

Conversation

priteshbandi
Copy link
Contributor

@priteshbandi priteshbandi commented Jan 12, 2024 •
edited
Loading

chore: start using plugin-framework package.

Note: we introduced a small breaking change; the type for GenerateSignatureResponse#SigningAlgorithm has been changed from string to plugin.SignatureAlgorithm

@priteshbandi priteshbandi mentioned this pull request Jan 12, 2024
Closed
Two-Hearts
Two-Hearts reviewed Jan 15, 2024
View reviewed changes
plugin/proto/metadata.go Show resolved Hide resolved
signer/plugin.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT requested changes Jan 15, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
plugin/plugin.go Show resolved Hide resolved
plugin/proto/errors.go Outdated Show resolved Hide resolved
@priteshbandi priteshbandi requested a review from toddysm as a code owner January 15, 2024 17:39
@priteshbandi
Add deprecation message
6acec9a 
Signed-off-by: Pritesh Bandi <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b7cd8a0) 73.24% compared to head (67dd576) 73.43%.
Report is 1 commits behind head on main.

Files Patch % Lines
signer/plugin.go 80.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   73.24%   73.43%   +0.18%     
==========================================
  Files          27       24       -3     
  Lines        2527     2507      -20     
==========================================
- Hits         1851     1841      -10     
+ Misses        536      526      -10     
  Partials      140      140

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JeyJeyGao
JeyJeyGao reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still many instances where the code uses proto.xxx that have not been replaced with notation-plugin-framework-go/plugin. Will we replace them?

plugin/proto/proto.go Outdated Show resolved Hide resolved
plugin/proto/proto.go Outdated Show resolved Hide resolved
plugin/plugin.go Outdated Show resolved Hide resolved
@priteshbandi
Copy link
Contributor Author

There are still many instances where the code uses proto.xxx that have not been replaced with notation-plugin-framework-go/plugin. Will we replace them?

Some code such as supporting methods not present notation-plugin-framework-go, unit tests will continue to use proto.xxx. We are not updating unit test to make sure we are backward compatible.

JeyJeyGao
JeyJeyGao reviewed Jan 31, 2024
View reviewed changes
plugin/proto/algorithm_test.go Outdated Show resolved Hide resolved
signer/plugin_test.go Show resolved Hide resolved
plugin/integration_test.go Show resolved Hide resolved
Two-Hearts
Two-Hearts approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think we should wait for Shiwei's comments regarding the PR.

@JeyJeyGao
Copy link
Contributor

LGTM
Pending on @shizhMSFT

shizhMSFT
shizhMSFT approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions on deprecation notices

plugin/proto/algorithm.go Show resolved Hide resolved
plugin/proto/algorithm.go Show resolved Hide resolved
plugin/proto/algorithm.go Show resolved Hide resolved
plugin/proto/errors.go Show resolved Hide resolved
plugin/proto/proto.go Show resolved Hide resolved
plugin/proto/proto.go Show resolved Hide resolved
plugin/proto/proto.go Show resolved Hide resolved
@priteshbandi
Copy link
Contributor Author

LGTM with suggestions on deprecation notices

Will merge the change and raised new PR for your suggestions.

rgnote
rgnote approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@rgnote rgnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 9ff1891 into notaryproject:main Feb 1, 2024
7 checks passed
@priteshbandi priteshbandi deleted the temp branch February 1, 2024 19:30
JeyJeyGao pushed a commit that referenced this pull request May 29, 2024
@priteshbandi @JeyJeyGao
chore: start using plugin-framework package (#372)
4096018 
**Note:** we introduced a small breaking change; the type for
`GenerateSignatureResponse#SigningAlgorithm` has been changed from
`string` to `plugin.SignatureAlgorithm`

---------

Signed-off-by: Pritesh Bandi <[email protected]>
This was referenced May 29, 2024
Closed
Closed
@Two-Hearts Two-Hearts mentioned this pull request Jul 23, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao left review comments

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@rgnote rgnote rgnote approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@priteshbandi @codecov-commenter @JeyJeyGao @rgnote @shizhMSFT @Two-Hearts