feat: add install method to plugin CLIManager #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT and
SteveLasker
as code owners
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
- Coverage 74.33% 73.34% -0.99%
==========================================
Files 24 27 +3
Lines 2260 2480 +220
==========================================
+ Hits 1680 1819 +139
- Misses 459 522 +63
- Partials 121 139 +18 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
reviewed
Nov 28, 2023
Signed-off-by: Patrick Zheng <[email protected]>
priteshbandi
reviewed
Dec 5, 2023
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
priteshbandi
previously approved these changes
Dec 14, 2023
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
reviewed
Dec 15, 2023
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
reviewed
Dec 15, 2023
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Installmethod toplugin.CLIManager.As suggested by @shizhMSFT:
when plugin path is a dir which contains a plugin executable file and extra files such as lib files and LICENSE files, all these files will be installed. A dir is considered a valid input if and only if
it contains one and only one valid plugin executable file named with format notaiton-{plugin-name}.Note: only regular files under the dir will be installed, sub-directories are ignored.
If the input plugin path is just a single executable file, this file will be installed.
When plugin already exists:
overwriteis set, version check is skipped. If the existing plugin is malfunctioning, directly overwrite it. If the existing plugin is valid, its plugin metadata is also returned for callers to consume.overwriteis not set, existing plugin MUST be valid, version check requires new plugin version MUST be higher than existing plugin version.When plugin does not exist: