Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update README to align with the new project brand #343

Merged
merged 12 commits into from
Nov 27, 2023
Merged

docs: update README to align with the new project brand #343

merged 12 commits into from
Nov 27, 2023

Conversation

FeynmanZhou
Copy link
Member

Resolve #323

@FeynmanZhou
update READNE
a13009f 
Signed-off-by: Feynman Zhou <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5de0d58) 74.33% compared to head (0ee2de0) 74.33%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   74.33%   74.33%           
=======================================
  Files          24       24           
  Lines        2260     2260           
=======================================
  Hits         1680     1680           
  Misses        459      459           
  Partials      121      121

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FeynmanZhou FeynmanZhou changed the title update READNE doc: update README to align with the new project brand Jul 27, 2023
@FeynmanZhou
update README
8c861c1 
Signed-off-by: Feynman Zhou <[email protected]>
yizha1
yizha1 reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FeynmanZhou just one comment

README.md Outdated Show resolved Hide resolved
@yizha1 yizha1 mentioned this pull request Jul 27, 2023
Closed
Two-Hearts
Two-Hearts previously approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comments.

Two-Hearts
Two-Hearts reviewed Aug 8, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Two-Hearts Two-Hearts self-requested a review August 8, 2023 02:26
@Two-Hearts Two-Hearts dismissed their stale review August 8, 2023 02:27

Having some comments

priteshbandi
priteshbandi reviewed Aug 17, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@FeynmanZhou
resolve comments
968fd0a 
Signed-off-by: Feynman Zhou <[email protected]>
Two-Hearts
Two-Hearts previously approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi reviewed Sep 4, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@priteshbandi
Update README.md
830b33b 
Co-authored-by: Pritesh Bandi <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Two-Hearts
Two-Hearts reviewed Oct 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT reviewed Oct 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
priteshbandi
priteshbandi reviewed Oct 26, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
FeynmanZhou and others added 2 commits October 27, 2023 17:39
@FeynmanZhou
refine READmE
c4064db 
Signed-off-by: Feynman Zhou <[email protected]>
Two-Hearts
Two-Hearts approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title doc: update README to align with the new project brand docs: update README to align with the new project brand Nov 6, 2023
yizha1
yizha1 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi
Copy link
Contributor

@FeynmanZhou Can you please sign the commit ?

@FeynmanZhou
Copy link
Member Author

FeynmanZhou commented Nov 23, 2023 •
edited
Loading

@priteshbandi @patrickzheng200 Thanks. I signed all commits. Now it is ready to be merged

@Two-Hearts Two-Hearts merged commit e8c8d22 into notaryproject:main Nov 27, 2023
12 checks passed
@Two-Hearts Two-Hearts mentioned this pull request Jan 24, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@yizha1 yizha1 yizha1 approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@JeyJeyGao JeyJeyGao Awaiting requested review from JeyJeyGao JeyJeyGao is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the README for the repository
6 participants
@FeynmanZhou @codecov-commenter @priteshbandi @shizhMSFT @yizha1 @Two-Hearts