Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin integration with verification workflow #101

Merged
merged 14 commits into from
Aug 19, 2022

Conversation

rgnote
Copy link
Contributor

@rgnote rgnote commented Aug 5, 2022

@rgnote rgnote changed the title Verification Plugin integration with verification workflow [WORK IN PROGRESS] Plugin integration with verification workflow [WORK IN PROGRESS] Aug 5, 2022
@rgnote rgnote changed the title Plugin integration with verification workflow [WORK IN PROGRESS] Plugin integration with verification workflow Aug 7, 2022
@rgnote rgnote requested review from gokarnm and qmuntal August 8, 2022 17:54
@dtzar dtzar added this to the alpha-3 milestone Aug 9, 2022
@gokarnm gokarnm requested a review from a team August 9, 2022 01:01
go.mod Outdated Show resolved Hide resolved
verification/verifier.go Outdated Show resolved Hide resolved
plugin/plugin.go Outdated Show resolved Hide resolved
verification/verifier.go Outdated Show resolved Hide resolved
verification/verifier_helpers.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #101 (29a39b9) into main (3f1301e) will increase coverage by 0.71%.
The diff coverage is 83.20%.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   71.95%   72.66%   +0.71%     
==========================================
  Files          36       36              
  Lines        2271     2491     +220     
==========================================
+ Hits         1634     1810     +176     
- Misses        511      544      +33     
- Partials      126      137      +11     
Impacted Files Coverage Δ
plugin/plugin.go 0.00% <0.00%> (ø)
verification/types.go 95.23% <62.50%> (-4.77%) ⬇️
verification/helpers.go 92.50% <72.72%> (-2.05%) ⬇️
verification/verifier_helpers.go 73.64% <76.52%> (-5.20%) ⬇️
verification/verifier.go 87.09% <97.22%> (+11.00%) ⬆️
signature/plugin.go 68.50% <100.00%> (ø)
signature/signer.go 51.80% <100.00%> (ø)
verification/errors.go 20.00% <0.00%> (+20.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: rgnote <[email protected]>
plugin/plugin.go Outdated Show resolved Hide resolved
verification/verifier.go Outdated Show resolved Hide resolved
verification/verifier_helpers.go Show resolved Hide resolved
verification/verifier_helpers.go Outdated Show resolved Hide resolved
verification/verifier_helpers.go Show resolved Hide resolved
verification/verifier.go Show resolved Hide resolved
verification/verifier_helpers.go Outdated Show resolved Hide resolved
verification/verifier_helpers.go Show resolved Hide resolved
verification/verifier.go Show resolved Hide resolved
internal/mock/mocks.go Outdated Show resolved Hide resolved
verification/verifier.go Show resolved Hide resolved
verification/verifier.go Outdated Show resolved Hide resolved
@notaryproject notaryproject deleted a comment from gokarnm Aug 11, 2022
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugin/plugin.go Outdated Show resolved Hide resolved
Copy link

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gokarnm gokarnm merged commit a9fb055 into notaryproject:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants