Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Semantic Versioning #102

Closed
rgnote opened this issue Aug 8, 2022 · 3 comments · Fixed by #237
Closed

Implement Semantic Versioning #102

rgnote opened this issue Aug 8, 2022 · 3 comments · Fixed by #237
Milestone

Comments

@rgnote
Copy link
Contributor

rgnote commented Aug 8, 2022

Notary V2 uses SemVer for plugin versioning. See spec here
At the time of writing this issue, Golang has no standard library support for parsing or comparing SemVer strings. This issue is to track implementing SemVer in Notation if no alternative is available. This issue is blocking using verification plugin minimum version critical attribute in signature verification workflow.

code:

// TODO verify the plugin's version is equal to or greater than `outcome.SignerInfo.SignedAttributes.HeaderVerificationPluginMinVersion`
// https://github.com/notaryproject/notation-go/issues/102

@shizhMSFT
Copy link
Contributor

@rgnote Golang has standard library support for parsing and comparing SemVer strings. Those libraries are live in the go mod repo (see github.com/golang/mod) where the semver package is available here.

@rgnote
Copy link
Contributor Author

rgnote commented Sep 13, 2022

@shizhMSFT Couple of issues with x/mod

  1. It requires versions to be prefixed with v
  2. Allows partial strings such as 1, 1.0, etc.

We may need to write a wrapper around it to make it work with Notation.

@priteshbandi priteshbandi added this to the RC-2 milestone Nov 23, 2022
@priteshbandi
Copy link
Contributor

PR #237

@priteshbandi priteshbandi linked a pull request Jan 13, 2023 that will close this issue
@yizha1 yizha1 moved this from Todo to In Progress in Notary Project Planning Board Jan 14, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Notary Project Planning Board Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants