Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: self-signed leaf certificate is not self-issued #236

Merged
merged 15 commits into from
Nov 5, 2024
Merged

fix: self-signed leaf certificate is not self-issued #236

merged 15 commits into from
Nov 5, 2024

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Oct 21, 2024 •
edited
Loading

Fix:

  • added self-issued check for self-signed leaf certificate
  • improved test coverage for x509 package
  • fixed test case for revocation package

Resolves #126

@JeyJeyGao JeyJeyGao marked this pull request as ready for review October 21, 2024 05:42
@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (1683ddb) to head (8ab3059).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   91.29%   91.70%   +0.40%     
==========================================
  Files          30       30              
  Lines        2608     2616       +8     
==========================================
+ Hits         2381     2399      +18     
+ Misses        173      165       -8     
+ Partials       54       52       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao JeyJeyGao marked this pull request as draft October 21, 2024 05:54
@JeyJeyGao
fix: improve test coverage
5cb2498 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: add license
e712676 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao force-pushed the fix/self_signed_cert branch from 8791202 to e712676 Compare October 21, 2024 07:27
@JeyJeyGao JeyJeyGao marked this pull request as ready for review October 21, 2024 07:30
shizhMSFT
shizhMSFT previously approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two-Hearts
Two-Hearts reviewed Oct 22, 2024
View reviewed changes
x509/helper.go Outdated Show resolved Hide resolved
@JeyJeyGao
fix: update comment
8240ff0 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: refactor test function
c124171 
Signed-off-by: Junjie Gao <[email protected]>
Two-Hearts
Two-Hearts reviewed Oct 22, 2024
View reviewed changes
x509/helper.go Outdated Show resolved Hide resolved
x509/codesigning_cert_validations.go Outdated Show resolved Hide resolved
x509/codesigning_cert_validations.go Outdated Show resolved Hide resolved
x509/timestamp_cert_validations.go Outdated Show resolved Hide resolved
@JeyJeyGao
Revert "fix: converge self-signed logic"
f8b8fbe 
This reverts commit c124171.

Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
Revert "fix: update comment"
48407c6 
This reverts commit 8240ff0.

Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao force-pushed the fix/self_signed_cert branch from 91432b0 to 9552c22 Compare October 23, 2024 03:20
@JeyJeyGao JeyJeyGao requested a review from Two-Hearts October 23, 2024 03:22
Two-Hearts
Two-Hearts approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 0c651a4 into notaryproject:main Nov 5, 2024
9 checks passed
@Two-Hearts Two-Hearts mentioned this pull request Dec 6, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

self-signed leaf cert validation issue
4 participants
@JeyJeyGao @priteshbandi @shizhMSFT @Two-Hearts