Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(signature): add two fuzz tests #229

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.76%. Comparing base (0786f51) to head (f40cd1c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files          30       30           
  Lines        2065     2065           
=======================================
  Hits         1895     1895           
  Misses        115      115           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title signature: add two fuzz tests test(signature): add two fuzz tests Sep 20, 2024
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi
Copy link
Contributor

@AdamKorcz can you please sign your commits?

@AdamKorcz
Copy link
Contributor Author

@AdamKorcz can you please sign your commits?

It should already be signed by way of git commit -s. Is there another way, I should do it?

@Two-Hearts
Copy link
Contributor

It should already be signed by way of git commit -s. Is there another way, I should do it?

@AdamKorcz The flag -s is for signoff. To fix, please try git commit --amend --no-edit -S --signoff. (note the capital S here).

Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
@AdamKorcz
Copy link
Contributor Author

git commit --amend --no-edit -S --signoff

Thank you! Done!

@Two-Hearts Two-Hearts merged commit e90546b into notaryproject:main Sep 24, 2024
9 checks passed
@Two-Hearts Two-Hearts mentioned this pull request Sep 24, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants