Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to codecov.io #19

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Migrate to codecov.io #19

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02e1fb7
Migrate to codecov.io
junczhu Jul 26, 2022
d1227cf
fix. remove extra space
junczhu Jul 26, 2022
54f2ddb
Doc. update README
junczhu Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/.codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
coverage:
status:
project:
default:
target: 89%
7 changes: 2 additions & 5 deletions .github/workflows/reusable-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,5 @@ jobs:
check-latest: true
- name: Run unit tests
run: make test
- name: Upload coverage report
uses: actions/upload-artifact@master
with:
name: notation-coverage-report-${{ github.sha }}
path: .cover/
- name: Upload coverage to codecov.io
uses: codecov/codecov-action@v3
3 changes: 1 addition & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@
.vscode

# Custom
.cover/
.test/
coverage.txt
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ all: test

.PHONY: test
test: check-line-endings ## run unit tests
./scripts/test.sh
go test -race -v -coverprofile=coverage.txt -covermode=atomic ./...

.PHONY: clean
clean:
Expand Down
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
# notation-core-go

[![codecov](https://codecov.io/gh/notatryproject/notation-core-go/branch/main/graph/badge.svg)](https://codecov.io/gh/notatryproject/notation-core-go)
Copy link
Contributor

@shizhMSFT shizhMSFT Jul 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[![codecov](https://codecov.io/gh/notatryproject/notation-core-go/branch/main/graph/badge.svg)](https://codecov.io/gh/notatryproject/notation-core-go)
[![codecov](https://codecov.io/gh/notaryproject/notation-core-go/branch/main/graph/badge.svg)](https://codecov.io/gh/notaryproject/notation-core-go)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README updated


Contains support for Notary v2 signature envelope, and format specific implementation
19 changes: 0 additions & 19 deletions scripts/test.sh
View file
Open in desktop

This file was deleted.