Add Shiwei Zhang as notation-core-go maintainer #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Zha <[email protected]>
yizha1
requested review from
toddysm,
sajayantony,
gokarnm,
rgnote,
binbin-li,
priteshbandi,
jondonas,
FeynmanZhou,
JeyJeyGao,
iamsamirzon,
patrickzheng200 and
vaninrao10
Signed-off-by: Yi Zha <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 90.28% 90.58% +0.29%
==========================================
Files 14 16 +2
Lines 1390 1434 +44
==========================================
+ Hits 1255 1299 +44
Misses 106 106
Partials 29 29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
LGTM but IANAM |
iamsamirzon
approved these changes
Feb 11, 2023
priteshbandi
pushed a commit
that referenced
this pull request
Feb 16, 2023
This PR combines all the changes from the following PRs for updating the maintainers for *notaryproject/notation-core-go* sub-project: [Add Junjie Gao](#114) #114 [Add Milind Gokarn](#109) #109 [Add Patrick Zheng](#113) #113 [Add Pritesh Bandi](#110) #110 [Add Rakesh Gariganti](#108 [Add Shiwei Zhang](#112) #112 The proposal is to abandon the above PRs and merge only this one. Signed-off-by: Toddy Mladenov <[email protected]>
|
Close as aggregated PR #118 was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Shiwei Zhang (@shizhMSFT) as a seed maintainer of
notation-core-gobased on their activity as per - #106Signed-off-by: Yi Zha [email protected]