Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove!: clean up time stamping code #102

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

shizhMSFT
Copy link
Contributor

Remove time stamping code as well as its dependencies since it is not scoped to 1.0.0-rc.2.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Merging #102 (bfd00ab) into main (2e9833f) will increase coverage by 11.54%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #102       +/-   ##
===========================================
+ Coverage   78.73%   90.28%   +11.54%     
===========================================
  Files          28       14       -14     
  Lines        2140     1390      -750     
===========================================
- Hits         1685     1255      -430     
+ Misses        346      106      -240     
+ Partials      109       29       -80     

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit a00bed9 into notaryproject:main Jan 20, 2023
@shizhMSFT shizhMSFT mentioned this pull request Feb 3, 2023
@shizhMSFT shizhMSFT deleted the cleanup branch February 3, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants