some more changes

Signed-off-by: Pritesh Bandi <[email protected]>
notaryproject · Jun 24, 2022 · 23d57cd · 23d57cd
1 parent 8ee5013
commit 23d57cd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/signer/jws_test.go b/signer/jws_test.go
@@ -10,6 +10,7 @@ import (
 	"testing"
 )
 
+// Tests various scenarios around newJWSEnvelopeFromBytes method
 func TestNewJWSEnvelopeFromBytes(t *testing.T) {
 	t.Run("newJWSEnvelopeFromBytes", func(t *testing.T) {
 		if _, err := newJWSEnvelopeFromBytes([]byte(TestValidSig)); err != nil {
@@ -24,6 +25,7 @@ func TestNewJWSEnvelopeFromBytes(t *testing.T) {
 	})
 }
 
+// Tests various scenarios around validateIntegrity method
 func TestValidateIntegrity(t *testing.T) {
 	t.Run("with newJWSEnvelope() returns error", func(t *testing.T) {
 		env := jwsEnvelope{}
@@ -76,6 +78,7 @@ func TestValidateIntegrity(t *testing.T) {
 	})
 }
 
+// Tests various scenarios around getSignerInfo method
 func TestGetSignerInfo(t *testing.T) {
 	t.Run("with newJWSEnvelope before sign returns error", func(t *testing.T) {
 		env := jwsEnvelope{}
@@ -142,6 +145,7 @@ func TestGetSignerInfo(t *testing.T) {
 	})
 }
 
+// Tests various scenarios around signPayload method
 func TestSignPayload(t *testing.T) {
 	env := jwsEnvelope{}
 	t.Run("using rsa key with newJWSEnvelope works", func(t *testing.T) {

diff --git a/signer/signer_test.go b/signer/signer_test.go
@@ -44,6 +44,7 @@ func TestNewSignatureEnvelopeFromBytesError(t *testing.T) {
 	}
 }
 
+// Tests various scenarios around generating a signature envelope
 func TestSign(t *testing.T) {
 	env, err := NewSignatureEnvelope(MediaTypeJWSJson)
 	if err != nil {
@@ -74,6 +75,7 @@ func TestSign(t *testing.T) {
 	})
 }
 
+// Tests various error scenarios around generating a signature envelope
 func TestSignErrors(t *testing.T) {
 	env, _ := NewSignatureEnvelope(MediaTypeJWSJson)
 	req := getSignRequest()
@@ -114,6 +116,7 @@ func TestSignErrors(t *testing.T) {
 	})
 }
 
+// Tests various scenarios around signature envelope verification
 func TestVerify(t *testing.T) {
 	certs := "MIIEfDCCAuSgAwIBAgIBAjANBgkqhkiG9w0BAQsFADBaMQswCQYDVQQGEwJVUzELMAkGA1UECBMCV0ExEDAOBgNVBAcTB1NlYXR0bGUxDzANBgNVBAoTBk5vdGFyeTEbMBkGA1UEAxMSTm90YXRpb24gVGVzdCBSb290MB4XDTIyMDYyMzA5MTkzOVoXDTIyMDYyNDA5MTkzOVowXzELMAkGA1UEBhMCVVMxCzAJBgNVBAgTAldBMRAwDgYDVQQHEwdTZWF0dGxlMQ8wDQYDVQQKEwZOb3RhcnkxIDAeBgNVBAMTF05vdGF0aW9uIFRlc3QgTGVhZiBDZXJ0MIIBojANBgkqhkiG9w0BAQEFAAOCAY8AMIIBigKCAYEA26n9XTnfViVMaPWJNe0YlYBfV80UB4ohpTTk/nAZX6IAYJemoN2MtUIgbdqxhKY1lvPnRh9RmzEwsk96auCKwTbqa7Z4FMtUg46GZqLWK5ioCg33hKRJnye/ENH2+iHy5MZUnXXfAZ89UG3Tq+LL8AJFykcw6XvslUUnw0m5aP+7fObF5SER5dpr7mMxArrVihvoDyjnfGRnDVljMwekrvKMzqCbg3qaCk6idETM7ylGZF9DzEk+mYxSnXUnGuxXTrc4bJYzx6Wb5Yio5srXWizOaTxtDZBWj0utdPxnJsQjVZzzhXQY7dbnO6ij8s6JYOl8fha+c/pUH47WSaXau7vSy1mwLhVZ6nTtNQ81H3/LStyZwpe49MgRHqcMmSXrxmXxnC1Ti5C1d+6GCvfLLtWJzy1mWNsLyrr5rVLbSS5yO67/fO+4zDdRp9hD7PlifAKUL4zHjY6fhFLwerDhnHKVw7iZStdpqgFYH3FPKQ9AV/ttVK7efclPDemy3DQ3AgMBAAGjSDBGMA4GA1UdDwEB/wQEAwIHgDATBgNVHSUEDDAKBggrBgEFBQcDAzAfBgNVHSMEGDAWgBSfTIFTcsegRVy3xoZXzz6we3Ek3DANBgkqhkiG9w0BAQsFAAOCAYEACKPOhYAcimneViZdeNTmP4Wdxoe4Vj4sk+NcuaZ2NwUUzQDA87CXRSt9oNP6+wQlp3ZJn1kxdoXO6DWD7iYU0XA/f+ejy7mV88My+NASaINMc18KPFr4kRMZxI0AgDNSdT0n3lfVzk0FBLXFGzA3ySMpUMvQZCCjc2leLoyktOxq4UHebslKQeHQJL3c/qta6UgkKvcInUPbXuFiQSTv2Kv2YqNdC1JHkKrM2Yw0zM5Uqybqhc8u8iH7H6gpDqFaHoDjsZD03PXBYkqX+PoQOjDsQ5+hm4pwYAIgxJORhcddnZ4GCCsWVnnsehdpzoh8P+w5+3i+7HnCv+vUsqd230BDIC6eUQ3Pa5o05tWjc35wspR6q2L/GXkDyRJ2h2/OsxH0UJR4VHUBEQU/pUaVyXMB75Qq2CwVvLcEUIacz27Sz1qdn26o6Kc3kmTkBSyXEfCxWD9Mmu+m/MLLjQFpAPchkpm9sDD8ZBLzS1lS1ZRS5T5kK2zc+tl0W/8PY7/1," +
 		"MIIEiTCCAvGgAwIBAgIBATANBgkqhkiG9w0BAQsFADBaMQswCQYDVQQGEwJVUzELMAkGA1UECBMCV0ExEDAOBgNVBAcTB1NlYXR0bGUxDzANBgNVBAoTBk5vdGFyeTEbMBkGA1UEAxMSTm90YXRpb24gVGVzdCBSb290MB4XDTIyMDYyMzA5MTkzOVoXDTIyMDcyMzA5MTkzOVowWjELMAkGA1UEBhMCVVMxCzAJBgNVBAgTAldBMRAwDgYDVQQHEwdTZWF0dGxlMQ8wDQYDVQQKEwZOb3RhcnkxGzAZBgNVBAMTEk5vdGF0aW9uIFRlc3QgUm9vdDCCAaIwDQYJKoZIhvcNAQEBBQADggGPADCCAYoCggGBAMsZBzyFRxJ65lOEkP3vnbOtldnFJGmmZswk++ZEfDrHXkyx3ywpReviw8JMH5Edht8ygMF3F+aNS9FQZU9fIlKK8SEqA+TMMPDIZgfIz5rrGZ0n36Mj3sgI8Wl+pjCGAfo0Z+Syj/v6YpHfBaKPaglqp6dBnXK1vHpJEL1rdtjUsWy7mFZ6awvrAAn9c2u9Z3mIbz3XmZ1aoQLbrC+A3xjwEWmMSkdw8Cl4n0kuH5YJQFan/f0F6XiRYieO3hazT9ES9JtZtVxeW2kZ/qqG/uAOy/bgavPGV7PHXg36+hxbGjQhOnxeV1WRjB+qXn3QWuEd/X2QmDXThZRBqhFqZLhykOItvmAFDXTcai5oo0aKxyY9frseQZ5bCbZhHBquLIZm1/gN7+A/V53d/dKfkUAGiI3i/Qid9bh+bIhqQ/9inI77msRu6cw8SdhEV+kl5HCzpgs6unqaDBuLullz16HuTAYMTIvGIrjkFVJ/3wxqKDNVofRxffh3uYEhFMTAAQIDAQABo1owWDAOBgNVHQ8BAf8EBAMCAgQwEwYDVR0lBAwwCgYIKwYBBQUHAwMwEgYDVR0TAQH/BAgwBgEB/wIBATAdBgNVHQ4EFgQUn0yBU3LHoEVct8aGV88+sHtxJNwwDQYJKoZIhvcNAQELBQADggGBAGl4jGFZ3GbqQGz7hZuZqb0jcUI7gwiqbxoaE52SRB1RuQTW6+dPF3vhEKcHcMxu2s4ABqETkzSe+93gJ38VT9NVi/YfqTVtwDuXIowUbMwFUp8EF81vZ9kh6EuiKbzDuWDFpQtn6wJv2UZgM6I9sSGyNE5CB5e+BwGWrw0764T2HWVUKm/EV2p3CI4fGDfCkktj4QAyK1HXgTpmza/ZZDFYvaUM6+sQHn39dEGOywS0HXoXuVR5ZpbWykBIfMBjwcQa1SGhrXTXQhSYSBA/Nhg2H8i7/MI85ugQNJPqzlb2PLKs/6AT8TZ8xs0nMdUq1X4gjCHN5+Y4ygcxH2Sy5trJfFfwZkI9RAOFvtWTFh4FvltN7lpmjI0C6ecdZaq1gfkvCpzV8YgpnWbRYpyL5OdzlMnpQqxgWgsCk5bqY1Zao/XJRb0pLaN5MVPkkitnJ+WvnEASP/GpIdS6XKcvZKvYmw4QWSZsg2N8peb3EwWYXuCq8PjKjI0ZsCU2eGjasw=="
@@ -157,6 +160,7 @@ func TestVerify(t *testing.T) {
 	}
 }
 
+// Tests various error scenarios around signature envelope verification
 func TestVerifyErrors(t *testing.T) {
 	t.Run("when trustedCerts is absent", func(t *testing.T) {
 		env, _ := NewSignatureEnvelopeFromBytes([]byte("{}"), MediaTypeJWSJson)
@@ -183,6 +187,7 @@ func TestVerifyErrors(t *testing.T) {
 	})
 }
 
+// Tests various scenarios around sign first and then verify envelope verification
 func TestSignAndVerify(t *testing.T) {
 	t.Run("with RSA certificate", func(t *testing.T) {
 		// Sign
@@ -251,6 +256,7 @@ func TestSignAndVerify(t *testing.T) {
 	})
 }
 
+// Tests various error scenarios around GetSignerInfo method
 func TestGetSignerInfoErrors(t *testing.T) {
 	env, _ := NewSignatureEnvelope(MediaTypeJWSJson)
 	t.Run("when called GetSignerInfo before sign or verify.", func(t *testing.T) {