Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version to 1.7.1, since 1.6.3 cannot build working binaries on OS X Sierra #984

Merged
merged 2 commits into from
Oct 1, 2016

Conversation

cyli
Copy link
Contributor

@cyli cyli commented Sep 30, 2016

Copy link
Contributor

@riyazdf riyazdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this, LGTM on green!

@@ -1 +1 @@
0.4.1
0.4.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also make a quick changelog note?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!

@cyli cyli force-pushed the bump-to-go1.7.1-for-sierra branch from a22e76f to 43850f7 Compare September 30, 2016 21:49
@@ -1,5 +1,8 @@
# Changelog

## [v0.4.2](https://github.com/docker/notary/releases/tag/v0.4.0) 9/30/2016
+ Bump the cross compiler to golang 1.7.1, since [1.6.3 builds binaries that could have non-deterministic bugs in OS X Sierra](https://groups.google.com/forum/#!msg/golang-dev/Jho5sBHZgAg/cq6d97S1AwAJ) [#984](https://github.com/docker/notary/pull/984)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cyli
Copy link
Contributor Author

cyli commented Sep 30, 2016

@justincormack approved. ping @endophage for one more +1?

@cyli cyli force-pushed the bump-to-go1.7.1-for-sierra branch from 43850f7 to 8e602b9 Compare September 30, 2016 22:42
Copy link
Contributor

@endophage endophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyli cyli merged commit 8263693 into notaryproject:hotfix/0.4.2 Oct 1, 2016
@cyli cyli deleted the bump-to-go1.7.1-for-sierra branch October 1, 2016 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants