Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expiry of fixture certs to at least 2 years in the future #951

Merged
merged 2 commits into from
Sep 12, 2016

Conversation

cyli
Copy link
Contributor

@cyli cyli commented Sep 12, 2016

Signed-off-by: Ying Li [email protected]

@riyazdf
Copy link
Contributor

riyazdf commented Sep 12, 2016

LGTM on green!

regenerate self-signed_docker.com-notary.crt and self-signed_secure.example.com.

Signed-off-by: Ying Li <[email protected]>
@cyli cyli force-pushed the update-cert-expiry branch from 2590d9f to 6976e9c Compare September 12, 2016 21:07
@cyli
Copy link
Contributor Author

cyli commented Sep 12, 2016

Updated this to do another 3 things:

  1. use a sha256 signing algorithm instead of whatever is default (which may be SHA1 on older versions of openssl, which we reject)
  2. use a different CN for the intermediate cert so we can more easily tell what signed what
  3. also generate 2 other certs that are in the fixtures library

@riyazdf
Copy link
Contributor

riyazdf commented Sep 12, 2016

thanks for the updates! LGTM pending CI :)

@endophage
Copy link
Contributor

LGTM

@endophage endophage merged commit 1285ab0 into notaryproject:release/0.4.0 Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants