Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a flag for auto publishing #886

Merged
merged 17 commits into from
Aug 9, 2016
Merged

Introduce a flag for auto publishing #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8a84d29
Introduce a flag for auto pubilshing
HuKeping Jul 29, 2016
c5cecf0
Address riyazdf's comments
HuKeping Aug 2, 2016
bd78254
Create a common function for auto publish
HuKeping Aug 3, 2016
65cc13e
Introduce auto publishing for notary init
HuKeping Aug 3, 2016
a232853
Introduce auto publish for notary remove
HuKeping Aug 3, 2016
df89d32
Add integration test for auto publishing
HuKeping Aug 3, 2016
57beb01
Rename function name
HuKeping Aug 4, 2016
3bf2441
Generate a constant for the help test of auto publish
HuKeping Aug 4, 2016
c518c71
Introduce auto publish for notary delegation add
HuKeping Aug 4, 2016
35f88eb
Fix golint
HuKeping Aug 4, 2016
ba98365
Introduce auto publish for notary delegation remove
HuKeping Aug 4, 2016
a451910
Add test for notary delegation add/remove with auto publish
HuKeping Aug 4, 2016
63057a3
Enhance test for auto publish
HuKeping Aug 5, 2016
e1e58ae
Introduce auto publish for notary addhash
HuKeping Aug 5, 2016
bcfee5f
Add test for notary addhash with auto publish
HuKeping Aug 5, 2016
82dffe0
Use require.Contains other than require.True when neccessary
HuKeping Aug 8, 2016
6c386a6
Refactor and clean up test
HuKeping Aug 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cmd/notary/delegations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ type delegationCommander struct {
paths []string
allPaths, removeAll, forceYes bool
keyIDs []string

autoPublish bool
}

func (d *delegationCommander) GetCommand() *cobra.Command {
Expand All @@ -66,11 +68,13 @@ func (d *delegationCommander) GetCommand() *cobra.Command {
cmdRemDelg.Flags().StringSliceVar(&d.paths, "paths", nil, "List of paths to remove")
cmdRemDelg.Flags().BoolVarP(&d.forceYes, "yes", "y", false, "Answer yes to the removal question (no confirmation)")
cmdRemDelg.Flags().BoolVar(&d.allPaths, "all-paths", false, "Remove all paths from this delegation")
cmdRemDelg.Flags().BoolVarP(&d.autoPublish, "publish", "p", false, htAutoPublish)
cmd.AddCommand(cmdRemDelg)

cmdAddDelg := cmdDelegationAddTemplate.ToCommand(d.delegationAdd)
cmdAddDelg.Flags().StringSliceVar(&d.paths, "paths", nil, "List of paths to add")
cmdAddDelg.Flags().BoolVar(&d.allPaths, "all-paths", false, "Add all paths to this delegation")
cmdAddDelg.Flags().BoolVarP(&d.autoPublish, "publish", "p", false, htAutoPublish)
cmd.AddCommand(cmdAddDelg)
return cmd
}
Expand Down Expand Up @@ -265,7 +269,7 @@ func (d *delegationCommander) delegationRemove(cmd *cobra.Command, args []string
}
cmd.Println("")

return nil
return maybeAutoPublish(cmd, d.autoPublish, gun, config, d.retriever)
}

// delegationAdd creates a new delegation by adding a public key from a certificate to a specific role in a GUN
Expand Down Expand Up @@ -359,5 +363,6 @@ func (d *delegationCommander) delegationAdd(cmd *cobra.Command, args []string) e
"Addition of delegation role %s %sto repository \"%s\" staged for next publish.\n",
role, addingItems, gun)
cmd.Println("")
return nil

return maybeAutoPublish(cmd, d.autoPublish, gun, config, d.retriever)
}
Loading