Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding --role flag to key import #882

Merged
merged 9 commits into from
Aug 10, 2016
Merged

adding --role flag to key import #882

merged 9 commits into from
Aug 10, 2016
+892 −43

Commits on Aug 10, 2016

  1. added -r, --role flag to CLI and the addition of specified role to th… 

    …e PEM data. need to write tests + address additional concerns

Signed-off-by: Avi Vaid <[email protected]>
    @avaid96
    avaid96 committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    c97ceff View commit details
    Browse the repository at this point in the history

  2. added functionality to import roles with gun and role along with role… 

    … defaults etc, need to write tests for this new functionality

Signed-off-by: Avi Vaid <[email protected]>
    @avaid96
    avaid96 committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    ad9ecf3 View commit details
    Browse the repository at this point in the history

  3. tests for path inference, block over flag precedence in import and er… 

    …rors when we don't have enough info to import a key

Signed-off-by: Avi Vaid <[email protected]>
    @avaid96
    avaid96 committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    7f709c9 View commit details
    Browse the repository at this point in the history

  4. fixed lint issues and added passphrase retriever for encryption of keys 

    Signed-off-by: Avi Vaid <[email protected]>
    @avaid96
    avaid96 committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    66be5d9 View commit details
    Browse the repository at this point in the history

  5. fixed make lint issues/errors 

    Signed-off-by: Avi Vaid <[email protected]>
    @avaid96
    avaid96 committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    1a5b332 View commit details
    Browse the repository at this point in the history

  6. made changes as per comments on PR 

    Signed-off-by: Avi Vaid <[email protected]>
    @avaid96
    avaid96 committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    13d986a View commit details
    Browse the repository at this point in the history

  7. cleaned up a lot of the control flow in key imports and added a bunch… 

    … of tests covering more cases, added a delegation add- import and publish flow test

Signed-off-by: Avi Vaid <[email protected]>
    @avaid96
    avaid96 committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    e19af6b View commit details
    Browse the repository at this point in the history

  8. addressed comments- made a bunch of fixes and added tests- main ones … 

    …being encryption tests and export import testflow test

Signed-off-by: Avi Vaid <[email protected]>
    @avaid96
    avaid96 committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    ba2508f View commit details
    Browse the repository at this point in the history

  9. added skip import if a key is imported to a non root canonical role w… 

    …ithout a gun

Signed-off-by: Avi Vaid <[email protected]>
    @avaid96
    avaid96 committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    d8a9ca9 View commit details
    Browse the repository at this point in the history