Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for indexes in rethink table.wait #834

Merged
merged 1 commit into from
Jul 15, 2016
Merged

Conversation

riyazdf
Copy link
Contributor

@riyazdf riyazdf commented Jul 14, 2016

We should call indexWait in addition to just the table wait to ensure that all indexes for the table are ready.

I can add unit-tests to the infrastructure in #824, though the rethink integration test checks out

Signed-off-by: Riyaz Faizullabhoy [email protected]

Signed-off-by: Riyaz Faizullabhoy <[email protected]>
@cyli
Copy link
Contributor

cyli commented Jul 14, 2016

@riyazdf Thanks for noticing this! And this LGTM! And sure, unit tests would be great. I'm not sure how to trigger indexes being slow to create, though.

@endophage
Copy link
Contributor

LGTM, good find!

I'm wondering if we can use a test wrapper for rethink that creates the indexes one by one with random delays between them? Work for a later time if it's even possible.

@endophage endophage merged commit 742dc2c into master Jul 15, 2016
@riyazdf riyazdf deleted the rethink-index-waiting branch July 15, 2016 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants