Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ineffassign in CI, fix ineffassign in code #830

Merged
merged 1 commit into from
Jul 13, 2016
Merged

Conversation

riyazdf
Copy link
Contributor

@riyazdf riyazdf commented Jul 11, 2016

Adds the ineffassign target to our Makefile and circle tests, indirectly part of #815

Signed-off-by: Riyaz Faizullabhoy [email protected]

@cyli
Copy link
Contributor

cyli commented Jul 12, 2016

LGTM! Thank you for adding this!

@cyli
Copy link
Contributor

cyli commented Jul 13, 2016

Non-blocking, but wondering if it'd be worth adding a full-lint endpoint that just combines all of these? That way we can run all the lints that are run on the CI with one command.

@endophage
Copy link
Contributor

Agree on adding a full-lint (could probably just be lint ??)

LGTM though. Merging

@endophage endophage merged commit 4020a59 into master Jul 13, 2016
@riyazdf riyazdf deleted the ineffassign branch July 14, 2016 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants