Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rethink and mysql server DB storage tests to run on circle #824

Merged
merged 8 commits into from
Jul 19, 2016
Merged

Set rethink and mysql server DB storage tests to run on circle #824

merged 8 commits into from
Jul 19, 2016

Commits on Jul 19, 2016

  1. Rename server and signer storage items to reflect the db type 

    Signed-off-by: Ying Li <[email protected]>
    @cyli
    cyli committed Jul 19, 2016
    Configuration menu
    Copy the full SHA
    ddb2860 View commit details
    Browse the repository at this point in the history

  2. Split SQL DB creation into a separate file so we can test against a r… 

    …eal MySQL server too

Signed-off-by: Ying Li <[email protected]>
    @cyli
    cyli committed Jul 19, 2016
    Configuration menu
    Copy the full SHA
    4f43dab View commit details
    Browse the repository at this point in the history

  3. Set up mysql server tests to run on circle 

    Signed-off-by: Ying Li <[email protected]>
    @cyli
    cyli committed Jul 19, 2016
    Configuration menu
    Copy the full SHA
    5feac09 View commit details
    Browse the repository at this point in the history

  4. Enable tests that require a rethink connection too, and add a bootstr… 

    …ap test.

Signed-off-by: Ying Li <[email protected]>
    @cyli
    cyli committed Jul 19, 2016
    Configuration menu
    Copy the full SHA
    c61be06 View commit details
    Browse the repository at this point in the history

  5. Refactor some of the TUF metadata storage tests to be more general, s… 

    …o they can be applied to rethink.

This also fixes the following bugs:

1.  MemStorage's UpdateMany previously did a partial update even if there was a conflict.
    Now we check for conflicts before updating.
2.  MemStorage's UpdateMany allowed you to insert the same version twice.
3.  RethinkDB's UpdateMany does a partial update even if there was a conflict, because the
    deletion criteria value (for timestamp_checksum) was passed as a list not as strings.
4.  RethinkDB's delete did not actually delete metadata, because the deletion criteria value
    (for gun) was passed as a list and not as strings.

Signed-off-by: Ying Li <[email protected]>
    @cyli
    cyli committed Jul 19, 2016
    Configuration menu
    Copy the full SHA
    e5c4e6b View commit details
    Browse the repository at this point in the history

  6. Fix lint issue, and reconfigure build scripts so db test and integrat… 

    …ion test are separate.

Signed-off-by: Ying Li <[email protected]>
    @cyli
    cyli committed Jul 19, 2016
    Configuration menu
    Copy the full SHA
    b76b1cb View commit details
    Browse the repository at this point in the history

  7. Fix comment and combine linting make targets into a single one. 

    Signed-off-by: Ying Li <[email protected]>
    @cyli
    cyli committed Jul 19, 2016
    Configuration menu
    Copy the full SHA
    2341a2a View commit details
    Browse the repository at this point in the history

  8. Fix a somewhat buggy testUpdateManyNoConflicts (as metadata is update… 

    …d old metadata is no longer current.

Also rename a variable to be more clear, and make invalid arguments to the integration/testdb scripts fail faster.

Signed-off-by: Ying Li <[email protected]>
    @cyli
    cyli committed Jul 19, 2016
    Configuration menu
    Copy the full SHA
    1eb6094 View commit details
    Browse the repository at this point in the history