-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import root cert in addition to root key #813
Conversation
Signed-off-by: Evan Cordell <[email protected]>
Please sign your commits following these rules: $ git clone -b "import_key_and_cert" [email protected]:dnwake/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Ammending updates the existing PR. You DO NOT need to open a new one. |
1 similar comment
Please sign your commits following these rules: $ git clone -b "import_key_and_cert" [email protected]:dnwake/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Ammending updates the existing PR. You DO NOT need to open a new one. |
Can one of the admins verify this patch? |
Signed-off-by: David Wake <[email protected]>
0058e41
to
f01a1bd
Compare
Please sign your commits following these rules: $ git clone -b "import_key_and_cert" [email protected]:dnwake/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Ammending updates the existing PR. You DO NOT need to open a new one. |
1 similar comment
Please sign your commits following these rules: $ git clone -b "import_key_and_cert" [email protected]:dnwake/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Ammending updates the existing PR. You DO NOT need to open a new one. |
Closing until I've been able to do more testing |
I've abandoned this pull request and created another here: #821 |
This change enables the optional flag --rootcert in addition to --rootkey.
If both --rootcert and --rootkey are specified, then the specified key and cert are both imported as the root keypair, provided they are compatible.
I haven't added a testcase yet, but would appreciate feedback. Thanks.