Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircleCI: update image, and use BuildKit #1486

Merged
merged 1 commit into from
Oct 22, 2019
Merged

CircleCI: update image, and use BuildKit #1486

merged 1 commit into from
Oct 22, 2019

Conversation

thaJeztah
Copy link
Contributor

YOLO; https://discuss.circleci.com/t/default-machine-executor-image-update/29308 mentioned CircleCI now has Docker 18.09, so let's see if this works

@thaJeztah thaJeztah force-pushed the use_buildkit_in_ci branch 6 times, most recently from 1bee2b5 to 71ee0a4 Compare August 16, 2019 13:26
@HuKeping
Copy link
Contributor

strange image name, why they give up using circleci at all?

@thaJeztah
Copy link
Contributor Author

yes, for this image they don't use the circleci prefix; I was confused as well, but 🤷‍♂️

@thaJeztah thaJeztah mentioned this pull request Aug 21, 2019
Merged
@HuKeping
Copy link
Contributor

As per https://discuss.circleci.com/t/default-machine-executor-image-update/29308, I'd like to merge this PR, otherwise we should change the image to circleci/classic:201710-01 which is tooooooooooooooooooooo old.

I don't like the image name without the prefix circleci , but it seems we have no better choice.

thoughts @justincormack ?

@thaJeztah
Copy link
Contributor Author

Also didn't try yet, but I think we can bring back parallelism by putting the steps from the circle-ci script into the circle-ci YAML (as it does allow stages to be executed in parallel).

This would also allow parameterising the docker build, and defining a matrix to test against multiple Go versions (adding a ARG GO_VERSION to the Dockerfiles, and overriding the default version in CI

@thaJeztah
Copy link
Contributor Author

Ah, looks like they changed policy?

Screenshot 2019-10-17 at 16 52 06

Let me comment that line

@thaJeztah thaJeztah force-pushed the use_buildkit_in_ci branch 2 times, most recently from fc95c95 to 44ffa34 Compare October 20, 2019 21:18
@thaJeztah
CircleCI: update image, and use BuildKit
6c3a239 
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@justincormack justincormack merged commit 4f9d594 into notaryproject:master Oct 22, 2019
@thaJeztah thaJeztah deleted the use_buildkit_in_ci branch October 22, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuKeping HuKeping HuKeping approved these changes

@justincormack justincormack justincormack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thaJeztah @HuKeping @justincormack