Do not build the osx cross packages when running CI tests #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endophage
reviewed
Nov 14, 2016
| @@ -1,4 +1,4 @@ | |||
| FROM golang:1.7.1 | |||
| FROM golang:1.7.3 | |||
There was a problem hiding this comment.
If the OSXCross stuff is no longer in here, can this (and should this) use alpine now?
There was a problem hiding this comment.
I originally tried that, but I ran into weird issues when running tests in alpine:
# runtime/race
race_linux_amd64.syso: In function `__sanitizer::InternalAlloc(unsigned long, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*, unsigned long)':
gotsan.cc:(.text+0x1631): undefined reference to `__libc_malloc'
race_linux_amd64.syso: In function `__sanitizer::GetArgv()':
gotsan.cc:(.text+0x43c3): undefined reference to `__libc_stack_end'
race_linux_amd64.syso: In function `__sanitizer::InternalRealloc(void*, unsigned long, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*)':
gotsan.cc:(.text+0x5580): undefined reference to `__libc_realloc'
race_linux_amd64.syso: In function `__sanitizer::ReExec()':
gotsan.cc:(.text+0x10337): undefined reference to `__libc_stack_end'
race_linux_amd64.syso: In function `__sanitizer::WriteOneLineToSyslog(char const*)':
gotsan.cc:(.text+0x4a97): undefined reference to `__syslog_chk'
race_linux_amd64.syso: In function `__sanitizer::InternalFree(void*, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*)':
gotsan.cc:(.text+0x55f8): undefined reference to `__libc_free'
collect2: error: ld returned 1 exit status
FAIL github.com/docker/notary/client [build failed]
I didn't know what that was, so I just stuck with debian for now :|
There was a problem hiding this comment.
No worries, just noticed the comment about not using alpine due to osxcross.
There was a problem hiding this comment.
Looks like it's golang/go#14481 - so for our CI tests, which run with -race enabled, I don't think we can use alpine :|
…akes a little while. Upgrade to go 1.7.3 from go 1.7.1 Remove the unnecessary "-dflags=-s" when building for OS X. Signed-off-by: Ying Li <[email protected]>
cyli
force-pushed
the
use-alpine-dockerfile-for-build
branch
from
7f3e02e to
3e6ba6d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this will shave at least 30 seconds from the CI times.
Also, bump up to go 1.7.3.
cc #1029