-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Clarify the Repository lifecycle #37
Conversation
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please make sure your governance outlines a supermajority and is linked here.
Signed-off-by: Feynman Zhou <[email protected]>
Having the process outlined is goodness. Archiving a repo that's been dormant may not mean the project isn't useful for others to consume as reference. It may just be stable and doesn't need additional changes. In this case, archiving can indicate it's stable, and not taking additional changes, because there aren't any maintainers, or the project is simply stable. I'd also suggest adding text that a repo must have at least 30 days notice to its maintainers before archival is completed. Deleting a project is far more destructive and removes content that others may need. I'd suggest we clarify under what circumstances a project would be deleted, vs. archived. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Just one comment.
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Thanks @SteveLasker for the suggestions. I added a paragraph about the archival notice and removed the "Removal" section according to your inputs above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FeynmanZhou
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about deleting, renaming, and transferring out a repository?
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
@shizhMSFT I added a section for Renaming. Deleting and transferring out a repository are not common cases so we could consider adding them in the future. Keep the content as minimum viable would be easier to review. |
Signed-off-by: Feynman Zhou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FeynmanZhou LGTM
/cc @notaryproject/notaryproject-governance-maintainers to help review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix #36