Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and migrate the release guideline #28

Closed
FeynmanZhou opened this issue May 17, 2023 · 4 comments · Fixed by notaryproject/notation#713
Closed

Refactor and migrate the release guideline #28

FeynmanZhou opened this issue May 17, 2023 · 4 comments · Fixed by notaryproject/notation#713
Assignees
Labels
Governance issues to improve governance posture

Comments

@FeynmanZhou
Copy link
Member

FeynmanZhou commented May 17, 2023

Hi @notaryproject/notaryproject-governance-maintainers @notaryproject/notaryproject-notation-maintainers ,

The RELEASE_CHECKLIST.md only covers a small part of the process and checklist. We need to update it by standing on the whole Notation project's point of view and involve notation-go and notation-core-go projects in this release guideline.

I propose migrating RELEASE_CHECKLIST.md
and RELEASE_MANAGEMENT.md from the Notation CLI repo to this repo and update them accordingly. Then add these two links on the Notary website.

@yizha1
Copy link
Contributor

yizha1 commented May 18, 2023

LGTM.
There is a https://github.com/notaryproject/notation/blob/main/RELEASE_MANAGEMENT.md under notation repo, which is also linked by Readme.md in Notation repo. We need to update those parts as well. And maybe under each subproject repo, link to the "new" release management document, so that folks jumped in any of the repo can be aware of it.

@toddysm
Copy link
Contributor

toddysm commented May 22, 2023

Let's start a PR for that change and iterate with comments in the PR. You can link the PR to this issue so they can go together.

@iamsamirzon
Copy link
Contributor

We have a choice to make between

  1. consolidate all guidelines in one doc but create different sections within the guidelines for each of the code repository - Notation CLI, Notation-go, Notation-core-go. Pros - No duplication; a single place within .github repo to manage; Cons - For anything in the .github repository, the org level maintainers will have to approve any PR, which will slow down the process
  2. Let each repo have its own well define release process. Pros - The maintainers of each repo can make their own decision and update their process amongst themselves. Cons - There will be some duplication.

@yizha1 yizha1 added the Governance issues to improve governance posture label Jul 12, 2023
@yizha1 yizha1 modified the milestones: 1.0.0, 1.1.0 Sep 5, 2023
@yizha1 yizha1 removed this from the 1.1.0 milestone Jan 16, 2024
@yizha1
Copy link
Contributor

yizha1 commented Jan 16, 2024

Remove from 1.1.0 milestone as it is not related to any features/bugs.

FeynmanZhou added a commit to notaryproject/notation that referenced this issue Jul 16, 2024
Update RELEASE_CHECKLIST.md per suggestions from [Notary Project
community meeting](https://hackmd.io/_vrqBGAOSUC_VWvFzWruZw?view#Notes)
and notaryproject/.github#28. Please note that
this PR focuses on updating the Notation CLI release process only.

I will create another PR to add the release checklist for releasing a
patch.

---------

Signed-off-by: Feynman Zhou <[email protected]>
Co-authored-by: Patrick Zheng <[email protected]>
@github-project-automation github-project-automation bot moved this from PR Review to Done in Notary Project Planning Board Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Governance issues to improve governance posture
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants