Allowed users to optinoally define number of sides on draw_circle and draw_circle_lines #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… draw_circle_lines
|
You should at least update all usages of this fuunction inside of macroquad so CI no longer fails and the crate can be built. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Circles look really bad with only 20 sides. Optionally being able to change that number will be good. I wanted to avoid creating a new method just for this so this is a breaking change as Rust doesn't support default field values for function parameters user will be forced to either add Some(u8) or None to these two function calls in they codebase. They can easily fix it with regex but it's still a little annoying breaking change for something simple. Maybe this can be merged when a new macroquad version releases.