Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented handling of all possible relay responses #59

Closed
wants to merge 1 commit into from
Closed

Implemented handling of all possible relay responses #59

wants to merge 1 commit into from

Conversation

kriptonix
Copy link
Contributor

  • Implemented relay responses. Each response has it's own class (RelayResponseOk, RelayResponseEvent, RelayResponseClosed, RelayResponseEose, RelayResponseNotice). For response type using enum (RelayResponseEnum).
  • Implemented response validation and added ERROR as response type in RelayResponseEnum to handle edge cases when response is not valid. When response is not valid we are using RelayResponseNotice to notify user with human-readable error message
  • EXTRA: Added URL verification in Relay class

@Sebastix Sebastix self-assigned this Jul 2, 2024
Sebastix added a commit that referenced this pull request Aug 16, 2024
@Sebastix
Extending the work done in PR #59 from @kriptonix
90dfa5a 
* improved relay responses in general
* NIP-01 relayResponses
* NIP-42 AUTH relayresponse
* added RelayResponseTest.php
@Sebastix
Copy link
Member

@kriptonix Thx for the work so far on this :) I don't know how to push changes to this PR, but I extended your work and can be reviewed here #60

@Sebastix Sebastix closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Sebastix Sebastix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kriptonix @Sebastix