-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make NIP-51 useful again #880
Conversation
Sounds good to me. |
51.md
Outdated
Then the user would create a 'Mute' list event like below: | ||
| name | kind | "d" tag | description | expected tag items | | ||
| --- | --- | --- | --- | --- | | ||
| Mute list | 30000 | `"mute"` | things the user doesn't want to see in their feeds | `"p"` (pubkeys), `"t"` (hashtags) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me sad. I know it's super common so we should document it but this feels very superfluous given we have 10000 mute lists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I just learned that Snort used kind 30000/"mute" but has now changed to kind 10000, so tides are in our favor. I changed the NIP and let's try to get this right this time.
…/"mute" and more examples.
Who is using kind 30000 with |
It would also be great if people could agree to move from kind 30001 with |
Looks good. If this gets sufficient support, I will switch Amethyst from using kind 30000's with d="mute" for mute lists to the 10000. |
I will, I think it's important. |
On Wed, Nov 15, 2023 at 05:38:29AM -0800, Vitor Pamplona wrote:
Looks good. If this gets approval, I will switch Amethyst from using
kind 30000's with d="mute" for mute lists to the 10000.
sure I will do the same.
|
curious as to why? I haven't followed these discussions. @staab |
@jb55 see my explanation in this comment. Since early on, user-defined lists in Coracle have been polluted with client-generated lists from other clients which don't make sense as user-generated lists (like "communities"). This is confusing to users because they never made those lists, and since clients can use any |
@staab not sure what you mean, do you query 30000 without a #d tag? |
Gossip has implemented categorized people list at 30000 with user-chosen 'd' tags. But the UI still hasn't exposed this implementation so nobody is using it yet, meaning we could still change things. The only list that is widely used in gossip is the Mute list 10000. |
I'm now trying to use private relay set, kind 30002. |
The only d-tag that matters is the public one. You can add one to private tag, but no relay will see it. Lists can have parts that are public and parts that are private at the same time. It's the same list (same public d-tag) |
All Primal clients already use kind 10000 for mute lists. We don't currently support pin, bookmark or communities lists, but once we do, we will go with the new 1000x kinds. |
@mutatrum the "follows sets" can accommodate private contact lists. Is this what you were looking for? |
No drama :) I like the proposal. ACK
What should we do with these examples? |
I think these do not fit into NIP-51, or do they? The Pinstr thing is more like a "spreadsheet table" NIP, and the the other one I don't get, where can I see it? |
What are Highlight lists @erskingardner? Was that a joke or do they exist? |
Yes maybe pinstr ones do not fit in nip51 due to its totally different convention to structure the data, but zap.stream ones are more like kind30023 since they are editable and use markdown for formatting.
https://github.com/v0l/zap.stream/blob/01eaf9996cfed9904906362c02597c65385102d1/src/const.ts#L9 |
The card itself is an event |
Any last additions or objections before we can merge this? |
Can we get devs to declare their current compliance level to these new changes? If 2+ clients are compliant, we merge. I am running behind with Amethyst. :( |
@vitorpamplona noStrudel is using:
|
Coracle's status:
Kind of hard to really meet the threshold of "2 clients" for this one because there are so many different list kinds being merged. But the PR has a record amount of client dev buy-in so it's probably fine. |
I will implement on nostree k30003 asap, but will continue to support k30001 read-only for a period of time. |
How about adding NIP-65 kind:10002 relays to standard lists table as reference? Public chats's kind:40 description seems to be wrong. |
What is wrong with the description? |
Kind:40 is channel definitions, isn't it? (at L27)
Seems to be copied from kind:34550 :) |
Oh, that took me a while to spot. |
Sorry, didn't see this until now. They're not a joke, @pablof7z uses them in Highlighter I believe (unless he's changed that). |
Agreed. Going to implement these changes in Listr this week (including making 30001 lists read-only). I'll also be adding a merge tool to help people migrate faster/easier. |
Ah yeah, I forgot I added those; 39802 (highlight is 9802 thus this number) |
https://github.com/nostr-protocol/nips/blob/save-nip-51/51.md
This NIP was a mess and wasn't being followed and there were many wild standards not documented. We should try to agree and actually follow some standards.
Also I've simplified the format to display some clearly defined simple tables so it's easier for people to add more stuff here.
We should stick to the 1xxxx range going forward for lists with standard meaning for which users are only expected to have one, 30001 for random lists and new 3xxxx lists for lists with standard meaning for which users are expected to have more than one.
Update:
This actually turned out to be a big movement involving tons of client developers in rehabilitating NIP-51, writing down old standards, creating new ones and cleaning up some mess from the past.