NIP-34!: use NIP-22 thread style for patch and status events
#1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deprecate NIP-10 style threading and replace with NIP-22 style for additional patches in patch set and patch revision roots. improve tag clarity for patch revisions omit repo ann tag for additional patches in set to enable filters that just include root and revision root patches. BREAKING CHANGE: NIP-34: replace NIP-10 style threading with NIP-22 for patch events
deprecate NIP-10 style threading and replace with NIP-22 style for additional status. merged patch event are referenced using the `q` tag even though the they are not included in `content`. this is because NIP-22 only supports the use of `e` reference for the parent event id. I (DanConwayDev) don't think this is worth making this change as it is breaking. BREAKING CHANGE: NIP-34: replace NIP-10 style threading with NIP-22 for status events
|
Nice! Looks great to me! |
|
Actually, I wonder if we should create a Patch Root kind and Patch Revision kinds. That's closer to how NIP-22 works (separate kinds for root and reply/revision) and avoids having to add Are patch revisions threads with multiple branches or just one branch? Does a revision include all the changes until that point or is the client supposed to apply the thread in sequence from root to leaf? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this as part of reviewing #1744. I don't think its worth merging these changes because the are breaking but I thought I'd share them anyway.
For the
statusevent, references to merged patch events are done using theqtag even though the they are not included in content. This is because NIP-22 only supports the use of e reference for the parent event id.