Add addDuration() to support Python >= 3.12 #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
changed the title
|
Thanks for contributing this! I'm going to read up a bit both on what we have in |
|
Okay, after reading through again, I don't think there's an obvious better quick solution. Probably this would translate to a new event type in nose2 if we wanted to continue to try to follow the model which exists, but I'm not sure that's such a great idea given the current age and status of the project (and how little time I end up making for it). Once again, thanks for not only identifying this but also putting in a PR with the fix. |
iilyak
added a commit
to apache/couchdb
that referenced
this pull request
May 15, 2024
The `unittest.TestCase` class in python 3.12 has a new addDuration method. The nose extends that class without providing the implementation for the method. This has been fixed in following PR nose-devs/nose2#570. The PR was included in 0.13. This version requires python >= 3.5. Which is a minimum required version for CouchDB as well. The original warning message (for 3.12/3.12.2_1) ``` The python version >= 3.12 doesn't provide 3.12/lib/python3.12/unittest/case.py:580: RuntimeWarning: TestResult has no addDuration method warnings.warn("TestResult has no addDuration method", ```
5 tasks
iilyak
added a commit
to apache/couchdb
that referenced
this pull request
May 15, 2024
The `unittest.TestCase` class in python 3.12 has a new addDuration method. The nose extends that class without providing the implementation for the method. This has been fixed in following PR nose-devs/nose2#570. The PR was included in 0.13. This version requires python >= 3.5. Which is a minimum required version for CouchDB as well. The original warning message (for 3.12/3.12.2_1) ``` The python version >= 3.12 doesn't provide 3.12/lib/python3.12/unittest/case.py:580: RuntimeWarning: TestResult has no addDuration method warnings.warn("TestResult has no addDuration method", ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A subset of #568
Fixes: #569
See the Python 3.12 changes discussed at #569 (comment)