Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: fixes splash screen loading #809

Conversation

comountainclimber
Copy link
Contributor

@comountainclimber comountainclimber commented Jan 6, 2019

Description

Previously the client splash screen => main menu loading was a a little wonky as the user would see first the grey window then the splash screen animation then the main window. This PR smooths out that process.

Motivation and Context

Makes the nOS client UX of loading the app much cleaner.

How Has This Been Tested?

Manual tested locally.

Screenshots (if appropriate)

BEFORE:
before-show-when-rdy

AFTER:
show-when-rdy

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #809 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #809   +/-   ##
========================================
  Coverage    54.17%   54.17%           
========================================
  Files          225      225           
  Lines         1914     1914           
  Branches       264      264           
========================================
  Hits          1037     1037           
  Misses         725      725           
  Partials       152      152

@comountainclimber comountainclimber changed the title updates src/main/index.js feature: fixes splash screen loading Jan 6, 2019
Copy link
Member

@DalderupMaurice DalderupMaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks! 😄

@DalderupMaurice DalderupMaurice merged commit 4089010 into nos:develop Jan 6, 2019
@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants