-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(forms): forward component refs to DOM elements #412
Conversation
7249dc8
to
e277d4c
Compare
Should be unblocked now 😄 |
@DalderupMaurice They merged that PR, but they haven't published it in a release yet. I've been following closely. 😁 |
e277d4c
to
9484a26
Compare
9484a26
to
54d2f66
Compare
Codecov Report
@@ Coverage Diff @@
## develop #412 +/- ##
===========================================
- Coverage 54.06% 52.82% -1.24%
===========================================
Files 156 154 -2
Lines 1230 1185 -45
Branches 156 150 -6
===========================================
- Hits 665 626 -39
+ Misses 477 471 -6
Partials 88 88 |
54d2f66
to
a0fafbd
Compare
This is unblocked now. I've got some tests to fix up, and then this will be golden. |
a0fafbd
to
ceac7bd
Compare
@DalderupMaurice This is ready for review now. 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :P
NOTE: This PR is blocked until enzymejs/enzyme#1604 is fixed via enzymejs/enzyme#1592.Description
This updates our form-based components to forward refs to the actual DOM element. This makes it so that the component does not need to expose functions specific to any element (e.g.:
focus()
,blur()
,value
).Motivation and Context
Components should behave in an intuitive manner.
How Has This Been Tested?
Via the test suite and smoke testing.
Screenshots (if appropriate)
N/A
Types of changes
Checklist
Documentation
Closing issues
N/A