Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency babel-eslint to v10.0.3 #1122

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 26, 2019

This PR contains the following updates:

Package Type Update Change
babel-eslint devDependencies patch 10.0.2 -> 10.0.3

Release Notes

babel/babel-eslint

v10.0.3

Compare Source

Fixes #​791, also eslint/eslint#​12117

Some context: #​793 (comment)

We ended up going with @​JLHwung's PR #​794 which uses ESLint's deps instead of going with peerDeps since it really depends on the version being used and we don't want users to have to install it directly on their own.

babel-eslint is patching patches of the dependencies of ESLint itself so these kinds of issues have happened in the past. We'll need to look into figuring out how to have a more solid way of modifying behavior instead of this monkeypatching type of thing for future releases.


Renovate configuration

📅 Schedule: "on monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot added the Renovate 🌴 Dependency update label Aug 26, 2019
@renovate renovate bot force-pushed the renovate/babel branch 2 times, most recently from 99da05d to a211998 Compare August 27, 2019 15:39
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #1122 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1122   +/-   ##
========================================
  Coverage    50.79%   50.79%           
========================================
  Files          240      240           
  Lines         2063     2063           
  Branches       276      276           
========================================
  Hits          1048     1048           
  Misses         843      843           
  Partials       172      172

@renovate renovate bot force-pushed the renovate/babel branch from a211998 to 6a256a4 Compare August 27, 2019 15:50
@renovate renovate bot force-pushed the renovate/babel branch from 6a256a4 to f04b99d Compare August 27, 2019 16:24
@DalderupMaurice DalderupMaurice merged commit b736977 into develop Aug 27, 2019
@DalderupMaurice DalderupMaurice deleted the renovate/babel branch August 27, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Renovate 🌴 Dependency update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants