filter out invalid candidate in sdp (awslabs#1260)

Co-authored-by: liyufang <[email protected]>
northteam · Sep 4, 2021 · ddff6df · ddff6df
1 parent c2e1c8c
commit ddff6df
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/source/Ice/IceAgent.c b/src/source/Ice/IceAgent.c
@@ -693,6 +693,7 @@ STATUS iceAgentPopulateSdpMediaDescriptionCandidates(PIceAgent pIceAgent, PSdpMe
     PDoubleListNode pCurNode = NULL;
     BOOL locked = FALSE;
     UINT32 attrIndex;
+    PIceCandidate pCandidate = NULL;
 
     CHK(pIceAgent != NULL && pSdpMediaDescription != NULL && pIndex != NULL, STATUS_NULL_ARG);
 
@@ -705,10 +706,12 @@ STATUS iceAgentPopulateSdpMediaDescriptionCandidates(PIceAgent pIceAgent, PSdpMe
     while (pCurNode != NULL) {
         CHK_STATUS(doubleListGetNodeData(pCurNode, &data));
         pCurNode = pCurNode->pNext;
-
-        STRCPY(pSdpMediaDescription->sdpAttributes[attrIndex].attributeName, "candidate");
-        CHK_STATUS(iceCandidateSerialize((PIceCandidate) data, pSdpMediaDescription->sdpAttributes[attrIndex].attributeValue, &attrBufferLen));
-        attrIndex++;
+        pCandidate = (PIceCandidate) data;
+        if (pCandidate->state == ICE_CANDIDATE_STATE_VALID) {
+            STRCPY(pSdpMediaDescription->sdpAttributes[attrIndex].attributeName, "candidate");
+            CHK_STATUS(iceCandidateSerialize((PIceCandidate) data, pSdpMediaDescription->sdpAttributes[attrIndex].attributeValue, &attrBufferLen));
+            attrIndex++;
+        }
     }
 
     *pIndex = attrIndex;